linux-kernel - Re: [RFC PATCH 16/31] cifs: Rewrite base TCP transmission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2577280.1754561571@warthog.procyon.org.uk>
Date: Thu, 07 Aug 2025 11:12:51 +0100
From: David Howells <dhowells@...hat.com>
To: Stefan Metzmacher <metze@...ba.org>
Cc: dhowells@...hat.com, Steve French <sfrench@...ba.org>,
    Paulo Alcantara <pc@...guebit.org>,
    Shyam Prasad N <sprasad@...rosoft.com>, Tom Talpey <tom@...pey.com>,
    Wang Zhaolong <wangzhaolong@...weicloud.com>,
    Mina Almasry <almasrymina@...gle.com>, linux-cifs@...r.kernel.org,
    linux-kernel@...r.kernel.org, netfs@...ts.linux.dev,
    linux-fsdevel@...r.kernel.org
Subject: Re: [RFC PATCH 16/31] cifs: Rewrite base TCP transmission

Stefan Metzmacher <metze@...ba.org> wrote:

> > + if (server->noblocksnd)
> > + smb_msg->msg_flags = MSG_DONTWAIT + MSG_NOSIGNAL;
> > + else
> > + smb_msg->msg_flags = MSG_NOSIGNAL;
> > + smb_msg->msg_flags = MSG_SPLICE_PAGES;
> > +
> 
> I guess you want '|=' instead of '=' in all 3 lines?

Well on the third line.  msg_flags is 0 on entry to the function.

> I also think msghdr should be setup in the caller completely
> or it should be a local variable in smb_sendmsg() and the caller
> only passes struct iov_iter.

Yeah, makes sense.

David