linux-kernel - Re: [PATCH 5/9] drm/xe: Update parameter generator to new signature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <zlgn7ymjtd4avnvccye55wongm5jz6oylzarmwuoqjxy4yeozi@cfly2cafnml2>
Date: Thu, 7 Aug 2025 07:59:05 -0300
From: Lucas De Marchi <lucas.demarchi@...el.com>
To: David Gow <davidgow@...gle.com>
CC: Marie Zhussupova <marievic@...gle.com>, <rmoar@...gle.com>,
	<shuah@...nel.org>, <brendan.higgins@...ux.dev>, <elver@...gle.com>,
	<dvyukov@...gle.com>, <thomas.hellstrom@...ux.intel.com>,
	<rodrigo.vivi@...el.com>, <linux-kselftest@...r.kernel.org>,
	<kunit-dev@...glegroups.com>, <kasan-dev@...glegroups.com>,
	<intel-xe@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/9] drm/xe: Update parameter generator to new signature

On Sat, Aug 02, 2025 at 05:44:48PM +0800, David Gow wrote:
>On Wed, 30 Jul 2025 at 03:37, Marie Zhussupova <marievic@...gle.com> wrote:
>>
>> This patch modifies `xe_pci_live_device_gen_param`
>> in xe_pci.c to accept an additional `struct kunit *test`
>> argument.
>>
>> Signed-off-by: Marie Zhussupova <marievic@...gle.com>
>> ---
>
>
>This is a pretty straightforward fix after patch 3. xe folks, would
>you prefer this kept as a separate patch, or squashed into patch 3
>(which changed the function signature)?

I don't like the breakage. Squashing would be much preferred.

thanks
Lucas De Marchi