linux-kernel - Re: [PATCH 02/10] ARM: dts: samsung: exynos4: Use SoC-specific compatible string for MFC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d835f3a-cc28-44f6-801f-c787f5e363d1@linaro.org>
Date: Thu, 7 Aug 2025 12:59:59 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Aakarsh Jain <aakarsh.jain@...sung.com>,
 linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org, m.szyprowski@...sung.com,
 andrzej.hajda@...el.com, mchehab@...nel.org, hverkuil-cisco@...all.nl,
 alim.akhtar@...sung.com, robh@...nel.org, conor+dt@...nel.org,
 devicetree@...r.kernel.org, krzysztof.kozlowski+dt@...aro.org
Cc: linux-samsung-soc@...r.kernel.org, aswani.reddy@...sung.com,
 anindya.sg@...sung.com
Subject: Re: [PATCH 02/10] ARM: dts: samsung: exynos4: Use SoC-specific
 compatible string for MFC

On 07/08/2025 12:59, Krzysztof Kozlowski wrote:
> On 07/08/2025 05:24, Aakarsh Jain wrote:
>> Modify the MFC device tree node to use a SoC-specific
>> compatible string instead of a generic one.
> 
> Why?
> 
>>
>> Signed-off-by: Aakarsh Jain <aakarsh.jain@...sung.com>
>> ---
>>  arch/arm/boot/dts/samsung/exynos4.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/samsung/exynos4.dtsi b/arch/arm/boot/dts/samsung/exynos4.dtsi
>> index ed47d0ce04e1..a2f15fbe98cb 100644
>> --- a/arch/arm/boot/dts/samsung/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/samsung/exynos4.dtsi
>> @@ -435,7 +435,7 @@ i2s2: i2s@...70000 {
>>  		};
>>  
>>  		mfc: codec@...00000 {
>> -			compatible = "samsung,mfc-v5";
>> +			compatible = "samsung,exynos4-mfc";
> 
> There are so many things wrong here...
> 
> 1. This breaks all users
> 2. Not a correct compatible - there is no exynos4 (see writing bindings)
> 3. Commit msg does not explain why breaking users is reasonable

Ah and 4: there is no such compatible, so this fails tests.

Best regards,
Krzysztof