[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250807111806.741706-1-inochiama@gmail.com>
Date: Thu, 7 Aug 2025 19:18:05 +0800
From: Inochi Amaoto <inochiama@...il.com>
To: Thomas Gleixner <tglx@...utronix.de>,
Paul Walmsley <paul.walmsley@...ive.com>,
Samuel Holland <samuel.holland@...ive.com>
Cc: Inochi Amaoto <inochiama@...il.com>,
linux-kernel@...r.kernel.org,
linux-riscv@...ts.infradead.org,
Yixun Lan <dlan@...too.org>,
Longbin Li <looong.bin@...il.com>
Subject: [PATCH] irqchip/sifive-plic: Respect mask state when setting affinity
The plic_set_affinity always call plic_irq_enable(), which clears up
the priority setting even the irq is only masked. This make the irq
unmasked unexpectly.
Replace the plic_irq_enable/disable() with plic_irq_toggle() to
avoid changing priority setting.
Suggested-by: Thomas Gleixner <tglx@...utronix.de>
Signed-off-by: Inochi Amaoto <inochiama@...il.com>
---
drivers/irqchip/irq-sifive-plic.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
index bf69a4802b71..5bf5050996da 100644
--- a/drivers/irqchip/irq-sifive-plic.c
+++ b/drivers/irqchip/irq-sifive-plic.c
@@ -148,6 +148,7 @@ static void plic_irq_enable(struct irq_data *d)
static void plic_irq_disable(struct irq_data *d)
{
+ plic_irq_mask(d);
plic_irq_toggle(irq_data_get_effective_affinity_mask(d), d, 0);
}
@@ -179,12 +180,14 @@ static int plic_set_affinity(struct irq_data *d,
if (cpu >= nr_cpu_ids)
return -EINVAL;
- plic_irq_disable(d);
+ /* Invalidate the original routing entry */
+ plic_irq_toggle(irq_data_get_effective_affinity_mask(d), d, 0);
irq_data_update_effective_affinity(d, cpumask_of(cpu));
+ /* Setting the new routing entry if irq is enabled */
if (!irqd_irq_disabled(d))
- plic_irq_enable(d);
+ plic_irq_toggle(irq_data_get_effective_affinity_mask(d), d, 1);
return IRQ_SET_MASK_OK_DONE;
}
--
2.50.1
Powered by blists - more mailing lists