linux-kernel - Re: [PATCH 3/3] cgroup/cpuset: Remove the unnecessary css_get/put() in cpuset_partition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7u4dmzplzjnj2v6l54xrabdy23laax6rwjhvt3lncbueoekfbc@g6ug5de6c7u2>
Date: Thu, 7 Aug 2025 13:25:57 +0200
From: Michal Koutný <mkoutny@...e.com>
To: Waiman Long <longman@...hat.com>
Cc: Tejun Heo <tj@...nel.org>, Johannes Weiner <hannes@...xchg.org>, 
	cgroups@...r.kernel.org, linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>, 
	Juri Lelli <juri.lelli@...hat.com>, "Peter Zijlstra (Intel)" <peterz@...radead.org>
Subject: Re: [PATCH 3/3] cgroup/cpuset: Remove the unnecessary css_get/put()
 in cpuset_partition_write()

On Wed, Aug 06, 2025 at 01:24:30PM -0400, Waiman Long <longman@...hat.com> wrote:
> The css_get/put() calls in cpuset_partition_write() are unnecessary as
> an active reference of the kernfs node will be taken which will prevent
> its removal and guarantee the existence of the css. Only the online
> check is needed.
> 
> Signed-off-by: Waiman Long <longman@...hat.com>
> ---
>  kernel/cgroup/cpuset.c | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Michal Koutný <mkoutny@...e.com>

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)