linux-kernel - Re: [PATCH] arm64: dts: st: Add memory-region-names property for stm32mp257f-ev1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48d20fc0-3212-499f-881f-9546607b250d@foss.st.com>
Date: Thu, 7 Aug 2025 13:49:29 +0200
From: Patrice CHOTARD <patrice.chotard@...s.st.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue
	<alexandre.torgue@...s.st.com>
CC: <devicetree@...r.kernel.org>, <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <stable@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: st: Add memory-region-names property for
 stm32mp257f-ev1



On 8/6/25 14:44, Krzysztof Kozlowski wrote:
> On 06/08/2025 14:36, Patrice CHOTARD wrote:
>>>> Signed-off-by: Patrice Chotard <patrice.chotard@...s.st.com>
>>>> ---
>>>>  arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts
>>>> index 2f561ad4066544445e93db78557bc4be1c27095a..16309029758cf24834f406f5203046ded371a8f9 100644
>>>> --- a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts
>>>> +++ b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts
>>>> @@ -197,6 +197,7 @@ &i2c8 {
>>>>  
>>>>  &ommanager {
>>>>  	memory-region = <&mm_ospi1>;
>>>> +	memory-region-names = "mm_ospi1";
>>>
>>> It does not look like you tested the DTS against bindings. Please run
>>> `make dtbs_check W=1` (see
>>
>> My bad, i am preparing the v2.
> Why? I claim this is not needed according to your description. You said
> it is necessary to identify "memory-map area's configuration." but
> memory-region already tells that. What exactly is not identified?

Sorry but memory-region doesn't tell if this area is dedicated to ospi1 or ospi2.

In order to set the AMCR register, which configure the memory-region split
between ospi1 and ospi2, we need to identify the ospi instance.

By using memory-region-names, it allows to identify the ospi instance it belongs to.

Thanks
Patrice

> 
> Best regards,
> Krzysztof