[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <000001dc0795$c0432660$40c97320$@samsung.com>
Date: Thu, 7 Aug 2025 17:51:02 +0530
From: "Pritam Manohar Sutar" <pritam.sutar@...sung.com>
To: "'Rob Herring'" <robh@...nel.org>
Cc: <vkoul@...nel.org>, <kishon@...nel.org>, <krzk+dt@...nel.org>,
<conor+dt@...nel.org>, <alim.akhtar@...sung.com>,
<andre.draszik@...aro.org>, <peter.griffin@...aro.org>,
<kauschluss@...root.org>, <ivo.ivanov.ivanov1@...il.com>,
<igor.belwon@...tallysanemainliners.org>, <m.szyprowski@...sung.com>,
<s.nawrocki@...sung.com>, <linux-phy@...ts.infradead.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>, <linux-samsung-soc@...r.kernel.org>,
<rosa.pila@...sung.com>, <dev.tailor@...sung.com>, <faraz.ata@...sung.com>,
<muhammed.ali@...sung.com>, <selvarasu.g@...sung.com>
Subject: RE: [PATCH v5 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add
ExynosAutov920 HS phy compatible
Hi Rob,
> -----Original Message-----
> From: Rob Herring <robh@...nel.org>
> Sent: 07 August 2025 05:12 AM
> To: Pritam Manohar Sutar <pritam.sutar@...sung.com>
> Cc: vkoul@...nel.org; kishon@...nel.org; krzk+dt@...nel.org;
> conor+dt@...nel.org; alim.akhtar@...sung.com; andre.draszik@...aro.org;
> peter.griffin@...aro.org; kauschluss@...root.org;
> ivo.ivanov.ivanov1@...il.com; igor.belwon@...tallysanemainliners.org;
> m.szyprowski@...sung.com; s.nawrocki@...sung.com; linux-
> phy@...ts.infradead.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> samsung-soc@...r.kernel.org; rosa.pila@...sung.com;
> dev.tailor@...sung.com; faraz.ata@...sung.com;
> muhammed.ali@...sung.com; selvarasu.g@...sung.com
> Subject: Re: [PATCH v5 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add
> ExynosAutov920 HS phy compatible
>
> On Tue, Aug 05, 2025 at 05:22:11PM +0530, Pritam Manohar Sutar wrote:
> > This SoC has USB2.0 phy and supports only UTMI+ interface. This phy
> > requires two clocks, named as "phy" and "ref". The required supplies
> > for this phy are vdd075_usb20(0.75v), vdd18_usb20(1.8v),
> vdd33_usb20(3.3v).
> >
> > Add a dedicated compatible string for USB HS phy found in this SoC.
> >
> > Signed-off-by: Pritam Manohar Sutar <pritam.sutar@...sung.com>
> > ---
> > .../bindings/phy/samsung,usb3-drd-phy.yaml | 19
> +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
> > b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
> > index e906403208c0..1932a2272ef9 100644
> > --- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-
> phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-
> phy.yaml
> > @@ -34,6 +34,7 @@ properties:
> > - samsung,exynos7870-usbdrd-phy
> > - samsung,exynos850-usbdrd-phy
> > - samsung,exynos990-usbdrd-phy
> > + - samsung,exynosautov920-usbdrd-phy
> >
> > clocks:
> > minItems: 1
> > @@ -110,6 +111,12 @@ properties:
> > vddh-usbdp-supply:
> > description: VDDh power supply for the USB DP phy.
> >
> > + dvdd075-usb20-supply:
> > + description: 0.75V power supply for the USB 2.0 phy.
> > +
> > + vdd18-usb20-supply:
> > + description: 1.8V power supply for the USB 2.0 phy.
> > +
> > required:
> > - compatible
> > - clocks
> > @@ -219,6 +226,7 @@ allOf:
> > - samsung,exynos7870-usbdrd-phy
> > - samsung,exynos850-usbdrd-phy
> > - samsung,exynos990-usbdrd-phy
> > + - samsung,exynosautov920-usbdrd-phy
> > then:
> > properties:
> > clocks:
> > @@ -235,6 +243,17 @@ allOf:
> >
> > reg-names:
> > maxItems: 1
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - samsung,exynosautov920-usbdrd-phy
> > + then:
> > + required:
> > + - dvdd075-usb20-supply
> > + - vdd18-usb20-supply
> > + - vdd33-usb20-supply
>
> Presumably the existing devices don't have these new supplies, so:
>
> else:
> properties:
> dvdd075-usb20-supply: false
> vdd18-usb20-supply: false
Appreciated for the suggestion. Will add this change in next version (v6) of
the patch-set.
Snippet will look as mentioned below.
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - samsung,exynosautov920-usbdrd-phy
+ then:
+ required:
+ - dvdd075-usb20-supply
+ - vdd18-usb20-supply
+ - vdd33-usb20-supply
+
+ else:
+ properties:
+ dvdd075-usb20-supply: false
+ vdd18-usb20-supply: false
Thank you.
Regards,
Pritam
Powered by blists - more mailing lists