linux-kernel - Re: [PATCH v3 2/3] usb: dwc3: qcom: Implement glue callbacks to facilitate runtime suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <abcbdb9a-f067-4bd1-be17-fe11b24dfacc@oss.qualcomm.com>
Date: Thu, 7 Aug 2025 14:56:55 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Krishna Kurapati <krishna.kurapati@....qualcomm.com>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>
Cc: linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
        Bjorn Andersson <bjorn.andersson@....qualcomm.com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v3 2/3] usb: dwc3: qcom: Implement glue callbacks to
 facilitate runtime suspend

On 8/7/25 7:17 AM, Krishna Kurapati wrote:
> 
> 
> On 8/6/2025 4:02 PM, Konrad Dybcio wrote:
>> On 8/6/25 11:58 AM, Krishna Kurapati wrote:
> 

[...]

>>> +    if (qcom->mode == USB_DR_MODE_HOST) {
>>> +        qcom->current_role = USB_ROLE_HOST;
>>> +    } else if (qcom->mode == USB_DR_MODE_PERIPHERAL) {
>>> +        qcom->current_role = USB_ROLE_DEVICE;
>>> +        dwc3_qcom_vbus_override_enable(qcom, true);
>>> +    } else {
>>> +        if ((device_property_read_bool(dev, "usb-role-switch")) &&
>>> +            (usb_get_role_switch_default_mode(dev) == USB_DR_MODE_HOST))
>>
>> currently this will never be true on any qcom dt ("role-switch-default-mode" is
>> not present anywhere)
> 
> Agree. But I wrote for the sake of covering all cases and just in case anyone uses this property tomorrow.

This is fine, just wanted to make sure this is intended

Konrad