linux-kernel - [PATCH] net: phy: motorcomm: make const array mac_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250807131504.463704-1-colin.i.king@gmail.com>
Date: Thu,  7 Aug 2025 14:15:04 +0100
From: Colin Ian King <colin.i.king@...il.com>
To: Frank <Frank.Sae@...or-comm.com>,
	Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] net: phy: motorcomm: make const array mac_addr_reg static

Don't populate the const read-only arrays mac_addr_reg on the stack at
run time, instead make them static, this reduces the object code size.

Size before:
   text	   data	    bss	    dec	    hex	filename
  65066	  11352	      0	  76418	  12a82	drivers/net/phy/motorcomm.o

Size after:
   text	   data	    bss	    dec	    hex	filename
  64761	  11512	      0	  76273	  129f1	drivers/net/phy/motorcomm.o

Reducton of 145 bytes (gcc 14.2.0 x86-64)

Signed-off-by: Colin Ian King <colin.i.king@...il.com>
---
 drivers/net/phy/motorcomm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
index 0e91f5d1a4fd..aeae7ec897c6 100644
--- a/drivers/net/phy/motorcomm.c
+++ b/drivers/net/phy/motorcomm.c
@@ -536,7 +536,7 @@ static void ytphy_get_wol(struct phy_device *phydev,
 static int ytphy_set_wol(struct phy_device *phydev, struct ethtool_wolinfo *wol)
 {
 	struct net_device *p_attached_dev;
-	const u16 mac_addr_reg[] = {
+	static const u16 mac_addr_reg[] = {
 		YTPHY_WOL_MACADDR2_REG,
 		YTPHY_WOL_MACADDR1_REG,
 		YTPHY_WOL_MACADDR0_REG,
@@ -608,7 +608,7 @@ static int ytphy_set_wol(struct phy_device *phydev, struct ethtool_wolinfo *wol)
 static int yt8531_set_wol(struct phy_device *phydev,
 			  struct ethtool_wolinfo *wol)
 {
-	const u16 mac_addr_reg[] = {
+	static const u16 mac_addr_reg[] = {
 		YTPHY_WOL_MACADDR2_REG,
 		YTPHY_WOL_MACADDR1_REG,
 		YTPHY_WOL_MACADDR0_REG,
-- 
2.50.1