linux-kernel - Re: [PATCH] drm/bridge: Remove unnecessary memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250807161859.09d2134f@booty>
Date: Thu, 7 Aug 2025 16:18:59 +0200
From: Luca Ceresoli <luca.ceresoli@...tlin.com>
To: Liao Yuanhong <liaoyuanhong@...o.com>
Cc: Andrzej Hajda <andrzej.hajda@...el.com>, Neil Armstrong
 <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>, Laurent
 Pinchart <Laurent.pinchart@...asonboard.com>, Jonas Karlman
 <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>, Maarten
 Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David Airlie
 <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Aradhya Bhatia
 <a-bhatia1@...com>, Dmitry Baryshkov <lumag@...nel.org>, Tomi Valkeinen
 <tomi.valkeinen@...asonboard.com>, dri-devel@...ts.freedesktop.org (open
 list:DRM DRIVERS), linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH] drm/bridge: Remove unnecessary memset

Hello Liao,

On Thu,  7 Aug 2025 20:38:33 +0800
Liao Yuanhong <liaoyuanhong@...o.com> wrote:

> kzalloc() has already been initialized to full 0 space, there is no need to
> use memset() to initialize again.
> 
> Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
> ---
>  drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> index a57ca8c3bdae..590f7c75744e 100644
> --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> @@ -1047,7 +1047,6 @@ cdns_dsi_bridge_atomic_reset(struct drm_bridge *bridge)
>  	if (!dsi_state)
>  		return NULL;
>  
> -	memset(dsi_state, 0, sizeof(*dsi_state));

Thanks, your patch seems correct, but your subject line should mention
the driver you are changing. You can use 
'git log --oneline -- <filename>'
to ensure which prefix is used for that file.

Without that your subject line would suggest you are changing the
drm_bridge core or doing a change affecting several drivers. That would
be misleading to reviewers receiving your patch as well as when looking
at the git history in case the patch gets applied (because the e-mail
Subject will be used as the git commit message title.

Best regards,
Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com