lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <nk2zd4agog5pqajeofiazo6aut7xekbj5jsvoe373lldfl2y2g@qngl743pigmr>
Date: Thu, 7 Aug 2025 20:29:12 +0530
From: Mahesh J Salgaonkar <mahesh@...ux.ibm.com>
To: Niklas Schnelle <schnelle@...ux.ibm.com>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>, Lukas Wunner <lukas@...ner.de>,
        Linas Vepstas <linasvepstas@...il.com>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Gerald Schaefer <gerald.schaefer@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        Matthew Rosato <mjrosato@...ux.ibm.com>,
        "Oliver O'Halloran" <oohall@...il.com>, Sinan Kaya <okaya@...nel.org>,
        linuxppc-dev@...ts.ozlabs.org, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
        Keith Busch <kbusch@...nel.org>
Subject: Re: [PATCH v5 3/3] powerpc/eeh: Use result of error_detected() in
 uevent

On 2025-08-07 15:55:40 Thu, Niklas Schnelle wrote:
> Ever since uevent support was added for AER and EEH with commit
> 856e1eb9bdd4 ("PCI/AER: Add uevents in AER and EEH error/resume"), it
> reported PCI_ERS_RESULT_NONE as uevent when recovery begins.
> 
> Commit 7b42d97e99d3 ("PCI/ERR: Always report current recovery status for
> udev") subsequently amended AER to report the actual return value of
> error_detected().
> 
> Make the same change to EEH to align it with AER and s390.
> 
> Suggested-by: Lukas Wunner <lukas@...ner.de>
> Link: https://lore.kernel.org/linux-pci/aIp6LiKJor9KLVpv@wunner.de/
> Reviewed-by: Lukas Wunner <lukas@...ner.de>
> Signed-off-by: Niklas Schnelle <schnelle@...ux.ibm.com>
> ---
>  arch/powerpc/kernel/eeh_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c
> index 7efe04c68f0fe3fb1c3c13d97d58e79e47cf103b..20ed9685da8b7e6d419a4b02f715b52acfe715d3 100644
> --- a/arch/powerpc/kernel/eeh_driver.c
> +++ b/arch/powerpc/kernel/eeh_driver.c
> @@ -334,7 +334,7 @@ static enum pci_ers_result eeh_report_error(struct eeh_dev *edev,
>  	rc = driver->err_handler->error_detected(pdev, pci_channel_io_frozen);
>  
>  	edev->in_error = true;
> -	pci_uevent_ers(pdev, PCI_ERS_RESULT_NONE);
> +	pci_uevent_ers(pdev, rc);
>  	return rc;
>  }

Thanks for the patch. Looks good to me.

Acked-by: Mahesh Salgaonkar <mahesh@...ux.ibm.com>

>  
> 
> -- 
> 2.48.1
> 
> 

-- 
Mahesh J Salgaonkar

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ