[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2a0a178a0929dc76cd88ec840d52043cd367451d@intel.com>
Date: Thu, 07 Aug 2025 21:07:59 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Qianfeng Rong <rongqianfeng@...o.com>, Maarten Lankhorst
<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
Simona Vetter <simona@...ll.ch>, "open list:DRM DRIVERS"
<dri-devel@...ts.freedesktop.org>, open list
<linux-kernel@...r.kernel.org>
Cc: willy@...radead.org, Qianfeng Rong <rongqianfeng@...o.com>
Subject: Re: [PATCH v2 1/2] drm/locking: remove redundant __GFP_NOWARN
On Thu, 07 Aug 2025, Qianfeng Rong <rongqianfeng@...o.com> wrote:
> GFP_NOWAIT already includes __GFP_NOWARN, so let's remove the redundant
> __GFP_NOWARN.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
Reviewed-by: Jani Nikula <jani.nikula@...el.com>
> ---
> drivers/gpu/drm/drm_modeset_lock.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_modeset_lock.c b/drivers/gpu/drm/drm_modeset_lock.c
> index beb91a13a312..58eac20a8138 100644
> --- a/drivers/gpu/drm/drm_modeset_lock.c
> +++ b/drivers/gpu/drm/drm_modeset_lock.c
> @@ -88,7 +88,7 @@ static noinline depot_stack_handle_t __drm_stack_depot_save(void)
>
> n = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
>
> - return stack_depot_save(entries, n, GFP_NOWAIT | __GFP_NOWARN);
> + return stack_depot_save(entries, n, GFP_NOWAIT);
> }
>
> static void __drm_stack_depot_print(depot_stack_handle_t stack_depot)
> @@ -98,7 +98,7 @@ static void __drm_stack_depot_print(depot_stack_handle_t stack_depot)
> unsigned int nr_entries;
> char *buf;
>
> - buf = kmalloc(PAGE_SIZE, GFP_NOWAIT | __GFP_NOWARN);
> + buf = kmalloc(PAGE_SIZE, GFP_NOWAIT);
> if (!buf)
> return;
--
Jani Nikula, Intel
Powered by blists - more mailing lists