linux-kernel - Re: [PATCH] media: uvcvideo: Log driver load in uvc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250807190525.GA28610@pendragon.ideasonboard.com>
Date: Thu, 7 Aug 2025 22:05:25 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
	Imene Jaziri <imenjazirii18@...il.com>, linux-media@...r.kernel.org,
	hansg@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: uvcvideo: Log driver load in uvc_probe function

On Thu, Aug 07, 2025 at 12:40:48PM -0600, Shuah Khan wrote:
> On 8/7/25 02:14, Laurent Pinchart wrote:
> > Hi Benjamin,
> > 
> > (CC'ing Shuah)
> > 
> > On Thu, Aug 07, 2025 at 09:53:41AM +0200, Benjamin Mugnier wrote:
> >> On 8/1/25 17:04, Laurent Pinchart wrote:
> >>> On Fri, Aug 01, 2025 at 03:53:26PM +0100, Imene Jaziri wrote:
> >>>> Add a pr_info() in the uvc_probe function to trace when the
> >>>> uvcvideo driver is loaded. This is for learning purposes.
> >>>
> >>> What part of the learning instructions you are following instructed you
> >>> to submit this patch to kernel mailing lists ? We are regularly spammed
> >>> by similar patches, which indicates the instructions are not clear
> >>> enough.
> >>>
> >>
> >> I got curious too. It comes from the Linux Foundation training LFD103
> >> [1]. Chapter 8 describes this patch pretty much, and chapter 9 describes
> >> how to send the patch, but with a warning not to do so :
> >>
> >>    [...]
> >>    At this time, you can run:
> >>
> >>    git format-patch -1 <commit ID> --to=maintainer1 --to=maintainer2
> >> --cc=maillist1 --cc=maillist2
> >>
> >>    This will generate a patch.
> >>
> >>    Important Note:
> >>    Please note that this is just an example. Don’t send this patch upstream.
> >>
> >>    You can revert this commit now.
> >>
> >>    Please refer to the Select the recipients for your patch section in
> >> the Submitting patches: the essential guide to getting your code into
> >> the kernel document.
> >>
> >>    When you have your own patch ready for submittal, you can follow this
> >> example process to generate the patch and send it upstream using the
> >> following command:
> >>
> >>    git send-email <patch_file>
> >>    [...]
> > 
> > Imene provided me with that information in private.
> > 
> >> Looking at it I guess it's pretty easy to miss the note.
> > 
> > Yes, reading the text, I really can't blame the people training the
> > course for missing it. It's a bit like if a mushroom foraging book said
> > 
> > - go pick those red mushrooms with white dots on the cap in the forest
> > - cut them in pieces, pan-fry them with butter
> > - add a couple of eggs, salt and pepper to make an omelette
> > - the dish is ready ! enjoy your meal !
> > - you won't be eating that, it's poisonous. throw it away
> > 
> > :-)
> > 
> >> Maybe
> >> requesting to add '--dry-run' to the git send-email command could be a
> >> simple fix to prevent from copy/pasting ?
> 
> No question that the material is confusing. The material is in
> a publicly available fee course.
> 
> > I've contacted Shuah, who told me she updated the training material.
> > Hopefully we'll soon stop getting such patches.
> 
> It is fixed now and the spam should stop. This course has been in
> use for 6 years, this is the first time we are seeing spam.

Just to be clear, I'm not blameing Imene here. I've received quite a few
similar patches over the last years.

> Sorry for the oversight that resulted in spam.

No worries, it happens.

-- 
Regards,

Laurent Pinchart