linux-kernel - Re: [PATCH] ethernet: liquidio: Remove unnecessary memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250807195849.GQ61519@horms.kernel.org>
Date: Thu, 7 Aug 2025 20:58:49 +0100
From: Simon Horman <horms@...nel.org>
To: Liao Yuanhong <liaoyuanhong@...o.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	"Dr. David Alan Gilbert" <linux@...blig.org>,
	"open list:CAVIUM LIQUIDIO NETWORK DRIVER" <netdev@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ethernet: liquidio: Remove unnecessary memset

On Thu, Aug 07, 2025 at 08:40:53PM +0800, Liao Yuanhong wrote:
> vzalloc_node() or vzalloc() has already been initialized to full 0 space,
> there is no need to use memset() to initialize again.
> 
> Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>

Looking over git, it seems that the last non-trivial change this driver
received was the following in 2018.

8bf6edcd96fc ("liquidio: Removed droq lock")

And moreover this driver is marked as Oprhaned.

So I would say that the churn of cleanup patches outweighs any benefit
to this driver. Let's leave it be.

-- 
pw-bot: cr