linux-kernel - Re: [PATCH] iio: light: ltr390: Add remove callback with needed support in device registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE3SzaSF0rQNt7iaz3qOa74tHk+tJyenticOzhrVCBazBPFpUg@mail.gmail.com>
Date: Fri, 8 Aug 2025 20:25:23 +0530
From: Akshay Jindal <akshayaj.lkd@...il.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: anshulusr@...il.com, jic23@...nel.org, dlechner@...libre.com, 
	nuno.sa@...log.com, andy@...nel.org, shuah@...nel.org, 
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: light: ltr390: Add remove callback with needed
 support in device registration

On Fri, Aug 8, 2025 at 8:04 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Fri, Aug 8, 2025 at 4:24 PM Akshay Jindal <akshayaj.lkd@...il.com> wrote:
> >
> > On Tue, Aug 5, 2025 at 6:18 PM Andy Shevchenko
> > <andy.shevchenko@...il.com> wrote:
> > > Are you sure about the remove stage and how it interacts with runtime
> > > PM? Please, check how the device driver core manages PM on the remove
> > > stage.
> > This driver does not even have support for runtime power management.
>
> Exactly. And my point is to enable it instead of playing tricks on ->remove().
Got it!!

>
> > Pardon me, but I am not able to see how runtime PM came into picture.
> > Am I missing something here?
> >
> > Code walkthrough says the remove call flows from
> > driver_unregister------__device_release_driver--------
> > dev->bus->remove ---- i2c_device_remove-----.remove() callback.
> >
> > Request you to correct me here.
>
> Right, and now find the PM runtime calls there. Put them in the
> picture and you will see my point.
>
Thanks Andy, will do that.

Regards,
Akshay