linux-kernel - Re: [PATCH] drm/nouveau/nvif: Fix potential memory leak in nvif_vmm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a657ead8-7f2c-4165-9a4c-ce4d82ea2adc@kernel.org>
Date: Sat, 9 Aug 2025 14:38:21 +0200
From: Danilo Krummrich <dakr@...nel.org>
To: Fanhua Li <lifanhua5@...wei.com>
Cc: dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
 liuyongqiang13@...wei.com, lyude@...hat.com, airlied@...il.com,
 simona@...ll.ch, airlied@...hat.com, linux-kernel@...r.kernel.org,
 suhui@...china.com
Subject: Re: [PATCH] drm/nouveau/nvif: Fix potential memory leak in
 nvif_vmm_ctor().

On 7/28/25 1:50 PM, Fanhua Li wrote:
> When the nvif_vmm_type is invalid, we will return error directly
> without freeing the args in nvif_vmm_ctor(), which leading a memory
> leak. Fix it by setting the ret -EINVAL and goto done.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/all/202312040659.4pJpMafN-lkp@intel.com/
> Fixes: 6b252cf42281 ("drm/nouveau: nvkm/vmm: implement raw ops to manage uvmm")
> Signed-off-by: Fanhua Li <lifanhua5@...wei.com>

Applied to drm-misc-fixes, thanks!