linux-kernel - Re: [PATCH 1/3] KEYS: trusted_tpm1: Compare HMAC values in constant time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250809172127.GA3339@quark>
Date: Sat, 9 Aug 2025 10:21:27 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: Jarkko Sakkinen <jarkko@...nel.org>
Cc: James Bottomley <James.Bottomley@...senpartnership.com>,
	Mimi Zohar <zohar@...ux.ibm.com>, keyrings@...r.kernel.org,
	David Howells <dhowells@...hat.com>,
	linux-integrity@...r.kernel.org, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 1/3] KEYS: trusted_tpm1: Compare HMAC values in constant
 time

On Sat, Aug 09, 2025 at 01:37:49PM +0300, Jarkko Sakkinen wrote:
> On Tue, Aug 05, 2025 at 10:32:27AM -0700, Eric Biggers wrote:
> > On Tue, Aug 05, 2025 at 04:44:27PM +0300, Jarkko Sakkinen wrote:
> > > On Thu, Jul 31, 2025 at 02:23:52PM -0700, Eric Biggers wrote:
> > > > To prevent timing attacks, HMAC value comparison needs to be constant
> > > > time.  Replace the memcmp() with the correct function, crypto_memneq().
> > > > 
> > > > Fixes: d00a1c72f7f4 ("keys: add new trusted key-type")
> > > > Cc: stable@...r.kernel.org
> > > > Signed-off-by: Eric Biggers <ebiggers@...nel.org>
> > > 
> > > Was crypto_memneq() available at the time?
> > 
> > No.  The Fixes commit is still correct, though, as it's the commit that
> > introduced the memcmp().  Technically it was still a bug at that time,
> > even if there wasn't a helper function available yet.
> 
> Add a remark to the commit message.

I don't know what the point is (both commits are over a decade old), but
sure I did that in v2.

- Eric