| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20250809184800.129831-13-joelagnelf@nvidia.com>
Date: Sat, 9 Aug 2025 14:47:57 -0400
From: Joel Fernandes <joelagnelf@...dia.com>
To: linux-kernel@...r.kernel.org,
Tejun Heo <tj@...nel.org>,
David Vernet <void@...ifault.com>,
Andrea Righi <arighi@...dia.com>,
Changwoo Min <changwoo@...lia.com>,
Ingo Molnar <mingo@...hat.com>,
Peter Zijlstra <peterz@...radead.org>,
Juri Lelli <juri.lelli@...hat.com>,
Vincent Guittot <vincent.guittot@...aro.org>,
Dietmar Eggemann <dietmar.eggemann@....com>,
Steven Rostedt <rostedt@...dmis.org>,
Ben Segall <bsegall@...gle.com>,
Mel Gorman <mgorman@...e.de>,
Valentin Schneider <vschneid@...hat.com>
Cc: Joel Fernandes <joelagnelf@...dia.com>,
sched-ext@...ts.linux.dev
Subject: [PATCH -rebased 12/15] sched_ext: Selectively enable ext and fair DL servers
Enable or disable the appropriate DL servers (ext and fair) depending on
whether an scx scheduler is started in full or partial mode:
- in full mode, disable the fair DL server and enable the ext DL server
on all online CPUs,
- in partial mode (%SCX_OPS_SWITCH_PARTIAL), keep both fair and ext DL
servers active to support tasks in both scheduling classes.
Additionally, handle CPU hotplug events by selectively enabling or
disabling the relevant DL servers on the CPU that is going
offline/online. This ensures correct bandwidth reseration also when CPUs
are brought online or offline.
Co-developed-by: Joel Fernandes <joelagnelf@...dia.com>
Signed-off-by: Andrea Righi <arighi@...dia.com>
---
kernel/sched/ext.c | 97 +++++++++++++++++++++++++++++++++++++++++-----
1 file changed, 87 insertions(+), 10 deletions(-)
diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
index 1f68f9e69d03..2e01a4ad34ff 100644
--- a/kernel/sched/ext.c
+++ b/kernel/sched/ext.c
@@ -3603,6 +3603,57 @@ static void set_cpus_allowed_scx(struct task_struct *p,
p, (struct cpumask *)p->cpus_ptr);
}
+static void dl_server_on(struct rq *rq, bool switch_all)
+{
+ struct rq_flags rf;
+ int err;
+
+ rq_lock_irqsave(rq, &rf);
+ update_rq_clock(rq);
+
+ if (switch_all) {
+ /*
+ * If all fair tasks are moved to the scx scheduler, we
+ * don't need the fair DL servers anymore, so remove it.
+ *
+ * When the current scx scheduler is unloaded, the fair DL
+ * server will be re-initialized.
+ */
+ if (dl_server_active(&rq->fair_server))
+ dl_server_stop(&rq->fair_server);
+ dl_server_remove_params(&rq->fair_server);
+ }
+
+ err = dl_server_init_params(&rq->ext_server);
+ WARN_ON_ONCE(err);
+
+ rq_unlock_irqrestore(rq, &rf);
+}
+
+static void dl_server_off(struct rq *rq, bool switch_all)
+{
+ struct rq_flags rf;
+ int err;
+
+ rq_lock_irqsave(rq, &rf);
+ update_rq_clock(rq);
+
+ if (dl_server_active(&rq->ext_server))
+ dl_server_stop(&rq->ext_server);
+ dl_server_remove_params(&rq->ext_server);
+
+ if (switch_all) {
+ /*
+ * Re-initialize the fair DL server if it was previously disabled
+ * because all fair tasks had been moved to the ext class.
+ */
+ err = dl_server_init_params(&rq->fair_server);
+ WARN_ON_ONCE(err);
+ }
+
+ rq_unlock_irqrestore(rq, &rf);
+}
+
static void handle_hotplug(struct rq *rq, bool online)
{
struct scx_sched *sch = scx_root;
@@ -3618,9 +3669,20 @@ static void handle_hotplug(struct rq *rq, bool online)
if (unlikely(!sch))
return;
- if (scx_enabled())
+ if (scx_enabled()) {
+ bool is_switching_all = READ_ONCE(scx_switching_all);
+
scx_idle_update_selcpu_topology(&sch->ops);
+ /*
+ * Update ext and fair DL servers on hotplug events.
+ */
+ if (online)
+ dl_server_on(rq, is_switching_all);
+ else
+ dl_server_off(rq, is_switching_all);
+ }
+
if (online && SCX_HAS_OP(sch, cpu_online))
SCX_CALL_OP(sch, SCX_KF_UNLOCKED, cpu_online, NULL, cpu);
else if (!online && SCX_HAS_OP(sch, cpu_offline))
@@ -4969,6 +5031,7 @@ static void scx_disable_workfn(struct kthread_work *work)
struct scx_exit_info *ei = sch->exit_info;
struct scx_task_iter sti;
struct task_struct *p;
+ bool is_switching_all = READ_ONCE(scx_switching_all);
int kind, cpu;
kind = atomic_read(&sch->exit_kind);
@@ -5024,6 +5087,22 @@ static void scx_disable_workfn(struct kthread_work *work)
scx_init_task_enabled = false;
+ for_each_online_cpu(cpu) {
+ struct rq *rq = cpu_rq(cpu);
+
+ /*
+ * Invalidate all the rq clocks to prevent getting outdated
+ * rq clocks from a previous scx scheduler.
+ */
+ scx_rq_clock_invalidate(rq);
+
+ /*
+ * We are unloading the sched_ext scheduler, we do not need its
+ * DL server bandwidth anymore, remove it for all CPUs.
+ */
+ dl_server_off(rq, is_switching_all);
+ }
+
scx_task_iter_start(&sti);
while ((p = scx_task_iter_next_locked(&sti))) {
const struct sched_class *old_class = p->sched_class;
@@ -5047,15 +5126,6 @@ static void scx_disable_workfn(struct kthread_work *work)
scx_task_iter_stop(&sti);
percpu_up_write(&scx_fork_rwsem);
- /*
- * Invalidate all the rq clocks to prevent getting outdated
- * rq clocks from a previous scx scheduler.
- */
- for_each_possible_cpu(cpu) {
- struct rq *rq = cpu_rq(cpu);
- scx_rq_clock_invalidate(rq);
- }
-
/* no task is on scx, turn off all the switches and flush in-progress calls */
static_branch_disable(&__scx_enabled);
bitmap_zero(sch->has_op, SCX_OPI_END);
@@ -5800,6 +5870,13 @@ static int scx_enable(struct sched_ext_ops *ops, struct bpf_link *link)
put_task_struct(p);
}
scx_task_iter_stop(&sti);
+
+ /*
+ * Enable the ext DL server on all online CPUs.
+ */
+ for_each_online_cpu(cpu)
+ dl_server_on(cpu_rq(cpu), !(ops->flags & SCX_OPS_SWITCH_PARTIAL));
+
percpu_up_write(&scx_fork_rwsem);
scx_bypass(false);
--
2.34.1
Powered by blists - more mailing lists