linux-kernel - Re: [PATCH 2/2] rtc: pcf85363: add support for additional features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202508091247.3Kc8Wms3-lkp@intel.com>
Date: Sat, 9 Aug 2025 12:39:20 +0800
From: kernel test robot <lkp@...el.com>
To: Lakshay Piplani <lakshay.piplani@....com>,
	alexandre.belloni@...tlin.com, linux-rtc@...r.kernel.org,
	linux-kernel@...r.kernel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, devicetree@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	vikash.bansal@....com, priyanka.jain@....com,
	shashank.rebbapragada@....com,
	Lakshay Piplani <lakshay.piplani@....com>
Subject: Re: [PATCH 2/2] rtc: pcf85363: add support for additional features

Hi Lakshay,

kernel test robot noticed the following build warnings:

[auto build test WARNING on abelloni/rtc-next]
[also build test WARNING on linus/master v6.16 next-20250808]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Lakshay-Piplani/rtc-pcf85363-add-support-for-additional-features/20250808-192449
base:   https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
patch link:    https://lore.kernel.org/r/20250808112246.4169280-2-lakshay.piplani%40nxp.com
patch subject: [PATCH 2/2] rtc: pcf85363: add support for additional features
config: i386-buildonly-randconfig-005-20250809 (https://download.01.org/0day-ci/archive/20250809/202508091247.3Kc8Wms3-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250809/202508091247.3Kc8Wms3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508091247.3Kc8Wms3-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/rtc/rtc-pcf85363.c:634:6: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
     634 |         if (ret)
         |             ^~~
   drivers/rtc/rtc-pcf85363.c:614:9: note: initialize the variable 'ret' to silence this warning
     614 |         int ret;
         |                ^
         |                 = 0
   1 warning generated.


vim +/ret +634 drivers/rtc/rtc-pcf85363.c

   605	
   606	/*
   607	 * Parses watchdog configuration from device tree and registers the
   608	 * watchdog with the Linux watchdog subsystem.
   609	 */
   610	static int pcf85363_watchdog_init(struct device *dev, struct regmap *regmap)
   611	{
   612		struct pcf85363_watchdog *wd;
   613		u32 timeout = 10, clock = 0;
   614		int ret;
   615	
   616		if (!IS_ENABLED(CONFIG_WATCHDOG) || !device_property_read_bool(dev, "nxp,enable-watchdog"))
   617			return 0;
   618	
   619		wd = devm_kzalloc(dev, sizeof(*wd), GFP_KERNEL);
   620		if (!wd)
   621			return -ENOMEM;
   622	
   623		wd->regmap = regmap;
   624		wd->dev = dev;
   625	
   626		device_property_read_u32(dev, "nxp,watchdog-timeout", &timeout);
   627		wd->timeout_val = clamp(timeout, WD_TIMEOUT_MIN, WD_TIMEOUT_MAX);
   628	
   629		device_property_read_u32(dev, "nxp,watchdog-stepsize", &clock);
   630		wd->clock_sel = clock & WD_CLKSEL_MASK;
   631	
   632		wd->repeat = device_property_read_bool(dev, "nxp,watchdog-repeat");
   633	
 > 634		if (ret)
   635			return ret;
   636	
   637		/* Clear any stale WDF flag */
   638		regmap_update_bits(regmap, CTRL_FLAGS, FLAGS_WDF, 0);
   639	
   640		/* Register the watchdog device */
   641		wd->wdd.info = &pcf85363_wdt_info;
   642		wd->wdd.ops = &pcf85363_wdt_ops;
   643		wd->wdd.min_timeout = WD_TIMEOUT_MIN;
   644		wd->wdd.max_timeout = WD_TIMEOUT_MAX;
   645		wd->wdd.timeout = wd->timeout_val;
   646		wd->wdd.parent = dev;
   647	
   648		/*
   649		 * For testing purposes, it's recommended to enable CONFIG_WATCHDOG_NOWAYOUT
   650		 * in the kernel configuration. If this option is not set, the watchdog may stop
   651		 * immediately after being started, especially if the user-space daemon closes
   652		 * /dev/watchdog without keeping it alive. Enabling NOWAYOUT ensures the watchdog
   653		 * remains active and can properly test system reset behavior.
   654		 */
   655		wd->wdd.status = WATCHDOG_NOWAYOUT_INIT_STATUS;
   656	
   657		watchdog_set_drvdata(&wd->wdd, wd);
   658	
   659		dev_info(dev, "pcf85363: watchdog initialized successfully\n");
   660	
   661		return devm_watchdog_register_device(dev, &wd->wdd);
   662	}
   663	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki