linux-kernel - Re: [PATCH] iommufd: viommu: free memory allocated by kvcalloc() using kvfree()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJjcpdioo/kTghlX@Asurada-Nvidia>
Date: Sun, 10 Aug 2025 10:53:41 -0700
From: Nicolin Chen <nicolinc@...dia.com>
To: Akhilesh Patil <akhilesh@...iitb.ac.in>
CC: <jgg@...pe.ca>, <kevin.tian@...el.com>, <joro@...tes.org>,
	<will@...nel.org>, <robin.murphy@....com>, <praan@...gle.com>,
	<baolu.lu@...ux.intel.com>, <jgg@...dia.com>, <iommu@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>, <akhileshpatilvnit@...il.com>,
	<skhan@...uxfoundation.org>
Subject: Re: [PATCH] iommufd: viommu: free memory allocated by kvcalloc()
 using kvfree()

On Sun, Aug 10, 2025 at 07:04:01PM +0530, Akhilesh Patil wrote:
> Use kvfree() instead of kfree() to free pages allocated by kvcalloc()
> in iommufs_hw_queue_alloc_phys() to fix potential memory corruption.
> Ensure the memory is properly freed, as kvcalloc may internally use
> vmalloc or kmalloc depending on available memory in the system.
> 
> Fixes: 2238ddc2b056 ("iommufd/viommu: Add IOMMUFD_CMD_HW_QUEUE_ALLOC ioctl")
> Signed-off-by: Akhilesh Patil <akhilesh@...iitb.ac.in>
 
Reviewed-by: Nicolin Chen <nicolinc@...dia.com>

Thanks!