linux-kernel - [PATCH] fwctl: mlx5: fix memory alloc/free in mlx5ctl_fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJjiRqLx9TEg2NFj@bhairav-test.ee.iitb.ac.in>
Date: Sun, 10 Aug 2025 23:47:42 +0530
From: Akhilesh Patil <akhilesh@...iitb.ac.in>
To: saeedm@...dia.com, itayavr@...dia.com, dave.jiang@...el.com,
	jgg@...pe.ca, Jonathan.Cameron@...wei.com
Cc: linux-kernel@...r.kernel.org, akhileshpatilvnit@...il.com,
	skhan@...uxfoundation.org
Subject: [PATCH] fwctl: mlx5: fix memory alloc/free in mlx5ctl_fw_rpc()

Use kvfree() to free memory allocated by kvzalloc() instead of kfree().
Avoid potential memory management issue by matching alloc/free routines.

Fixes: 52929c2142041 ("fwctl/mlx5: Support for communicating with mlx5 fw")
Signed-off-by: Akhilesh Patil <akhilesh@...iitb.ac.in>
---
 drivers/fwctl/mlx5/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fwctl/mlx5/main.c b/drivers/fwctl/mlx5/main.c
index f93aa0cecdb9..4b379f695eb7 100644
--- a/drivers/fwctl/mlx5/main.c
+++ b/drivers/fwctl/mlx5/main.c
@@ -345,7 +345,7 @@ static void *mlx5ctl_fw_rpc(struct fwctl_uctx *uctx, enum fwctl_rpc_scope scope,
 	 */
 	if (ret && ret != -EREMOTEIO) {
 		if (rpc_out != rpc_in)
-			kfree(rpc_out);
+			kvfree(rpc_out);
 		return ERR_PTR(ret);
 	}
 	return rpc_out;
-- 
2.34.1