linux-kernel - Re: [PATCH net] rds: Fix endian annotations across various assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63a22c3c-ee9b-44cd-9e5a-a68bb366eba5@lunn.ch>
Date: Sun, 10 Aug 2025 22:19:54 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Ujwal Kundur <ujwal.kundur@...il.com>
Cc: Al Viro <viro@...iv.linux.org.uk>, allison.henderson@...cle.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, horms@...nel.org, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org, rds-devel@....oracle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] rds: Fix endian annotations across various
 assignments

> > This smells of an LLM generated patch. So i think you are somewhat
> > wasting your time explaining in detail why this is wrong.
> I have never used (and will not use) LLMs :(

Sorry, I need to refine my sense of smell.

> P.S: I'm still learning the ropes as a contributor so please pardon my
> ignorance.

You might find this interesting:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

You made a few process errors as well. Since you submitted this to
net, it needs a Fixes: tag.

Also:

https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

Particularly:

	It must either fix a real bug that bothers people

Sparse warnings don't really both people. But is the sparse warning
indicating a read bug which does bother people? If so, net is O.K, but
please add to the commit message what the real bug is. If this is
simply cleanup, not a bug fix, please submit to net-next.

You can also learn a lot by subscribing to the netdev mailing list,
and reading other peoples patches, and review comments they get.

	Andrew