linux-kernel - Re: [PATCH v2 11/13] rust: block: replace `core::mem::zeroed` with `pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DBYKSUYMQPEC.16UUNM5ALNR6Z@kernel.org>
Date: Sun, 10 Aug 2025 09:40:15 +0200
From: "Benno Lossin" <lossin@...nel.org>
To: "Andreas Hindborg" <a.hindborg@...nel.org>, "Boqun Feng"
 <boqun.feng@...il.com>, "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Alice Ryhl"
 <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>, "Danilo
 Krummrich" <dakr@...nel.org>, "Jens Axboe" <axboe@...nel.dk>, "Yutaro Ohno"
 <yutaro.ono.418@...il.com>, "Xizhe Yin" <xizheyin@...il.nju.edu.cn>,
 "Manas" <manas18244@...td.ac.in>, "Fiona Behrens" <me@...enk.dev>
Cc: "Lyude Paul" <lyude@...hat.com>, <linux-block@...r.kernel.org>,
 <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 11/13] rust: block: replace `core::mem::zeroed` with
 `pin_init::zeroed`

On Sun Aug 10, 2025 at 9:21 AM CEST, Andreas Hindborg wrote:
> "Benno Lossin" <lossin@...nel.org> writes:
>
>> On Fri Aug 8, 2025 at 11:35 AM CEST, Andreas Hindborg wrote:
>>> "Benno Lossin" <lossin@...nel.org> writes:
>>>
>>>> All types in `bindings` implement `Zeroable` if they can, so use
>>>> `pin_init::zeroed` instead of relying on `unsafe` code.
>>>>
>>>> If this ends up not compiling in the future, something in bindgen or on
>>>> the C side changed and is most likely incorrect.
>>>>
>>>> Signed-off-by: Benno Lossin <lossin@...nel.org>
>>>> ---
>>>
>>> Acked-by: Andreas Hindborg <a.hindborg@...nel.org>
>>
>> Thanks, this one was already picked & the PR that included it contains
>> your Acked-by (it couldn't be rebased since I noticed it too late). Let
>> me know if you need any pointers.
>
> Right, I remember now that you point it out. It's just because I got a
> new fancy email filter (lei q dfn:...). Hopefully I will miss fewer of
> these in the future.

That's nice and no worries, I should have pinged you before applying :)

---
Cheers,
Benno