linux-kernel - Re: [PATCH] m68k: Add target for lz4 compressed vmlinux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFr9PXkJCPm9UwV8-FeZxhB+ODxGgtbKdD3n90UjqyPGF8tMSw@mail.gmail.com>
Date: Sun, 10 Aug 2025 18:08:15 +0900
From: Daniel Palmer <daniel@...f.com>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: geert@...ux-m68k.org, linux-m68k@...ts.linux-m68k.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k: Add target for lz4 compressed vmlinux

Hi Thomas,

On Sat, 9 Aug 2025 at 21:29, Thomas Weißschuh <linux@...ssschuh.net> wrote:
>
> Hi Daniel,
>
> On 2025-08-09 20:35:39+0900, Daniel Palmer wrote:
> > On Sat, 9 Aug 2025 at 16:50, Thomas Weißschuh <linux@...ssschuh.net> wrote:
> I would continue with vmlinux.tmp. It might not actually be stripped.
>
> quiet_cmd_precompress = PRECOMPRESS $@
> ifndef CONFIG_KGDB
>       cmd_precompress = cp $< $@
> else
>       cmd_precompress = $(STRIP) $< -o $@
> endif
>
> vmlinux.tmp: vmlinux FORCE
>         $(call if_changed,precompress)
>
> targets += vmlinux.tmp
>
> This will also correctly handle CONFIG_KGDB changing.
>
> (Maybe the naming can be improved)

Nice, that's a lot better and I've reworked my patch to do that.

> And for the compressor invocations we already have predefined commands:
>
> vmlinux.gz: vmlinux.tmp FORCE
>         $(call if_changed,gzip)

I also did this for all of the targets and $(call if_changed,lz4)
results in an lz4 file with the old header format[0] and 8MB block
size which is not what I need.
So v2 will have a patch to add a helper to generate that style of lz4
in scripts/Makefile.lib

Thanks!,

Daniel

0 - https://github.com/lz4/lz4/blob/dev/doc/lz4_Frame_format.md#legacy-frame