linux-kernel - Re: [PATCH 1/3] bcache: remove redundant __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae3417a3-c3df-4c6e-8a27-2ba71eb1e53b@vivo.com>
Date: Mon, 11 Aug 2025 21:46:50 +0800
From: Qianfeng Rong <rongqianfeng@...o.com>
To: Coly Li <colyli@...nel.org>
Cc: Kent Overstreet <kent.overstreet@...ux.dev>,
 "open list:BCACHE (BLOCK LAYER CACHE)" <linux-bcache@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] bcache: remove redundant __GFP_NOWARN


在 2025/8/11 21:22, Coly Li 写道:
> On Mon, Aug 11, 2025 at 08:36:35PM +0800, Qianfeng Rong wrote:
>> GFP_NOWAIT already includes __GFP_NOWARN, so let's remove the redundant
>> __GFP_NOWARN.
>>
>> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
> Acked-by: Coly Li <colyli@...nel.org>
>
> Do you want this patch to go upstream in my submission path?
Yes, please include this patch in your submission path to upstream.

Thank you for your review and Acked-by tag.

Best regards,
Qianfeng
>
> Thanks.
>
> Coly Li
>
>> ---
>>   drivers/md/bcache/btree.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
>> index 210b59007d98..a764ec149d7a 100644
>> --- a/drivers/md/bcache/btree.c
>> +++ b/drivers/md/bcache/btree.c
>> @@ -371,7 +371,7 @@ static void do_btree_node_write(struct btree *b)
>>   	SET_PTR_OFFSET(&k.key, 0, PTR_OFFSET(&k.key, 0) +
>>   		       bset_sector_offset(&b->keys, i));
>>   
>> -	if (!bch_bio_alloc_pages(b->bio, __GFP_NOWARN|GFP_NOWAIT)) {
>> +	if (!bch_bio_alloc_pages(b->bio, GFP_NOWAIT)) {
>>   		struct bio_vec *bv;
>>   		void *addr = (void *) ((unsigned long) i & ~(PAGE_SIZE - 1));
>>   		struct bvec_iter_all iter_all;
>> -- 
>> 2.34.1
>>