linux-kernel - Re: [RFC PATCH v4 2/3] virtio-spi: Add virtio-spi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJn1Chsfe5297OTa@black.igk.intel.com>
Date: Mon, 11 Aug 2025 15:50:02 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Haixu Cui <quic_haixcui@...cinc.com>
Cc: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>, broonie@...nel.org,
	virtio-dev@...ts.oasis-open.org, viresh.kumar@...aro.org,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	hdanton@...a.com, qiang4.zhang@...ux.intel.com,
	alex.bennee@...aro.org, quic_ztu@...cinc.com
Subject: Re: [RFC PATCH v4 2/3] virtio-spi: Add virtio-spi.h

On Fri, Apr 25, 2025 at 04:24:25PM +0800, Haixu Cui wrote:

...
1
> > > +#define VIRTIO_SPI_RX_TX_SUPPORT_DUAL (1 << 0)
> > > +#define VIRTIO_SPI_RX_TX_SUPPORT_QUAD (1 << 1)
> > > +#define VIRTIO_SPI_RX_TX_SUPPORT_OCTAL (1 << 2)
> > Can use BIT(x) ?
> Will update the code accordingly:
> #define VIRTIO_SPI_RX_TX_SUPPORT_DUAL    BIT(0)
> #define VIRTIO_SPI_RX_TX_SUPPORT_QUAD    BIT(1)

Please, do not do this.
I explained more in the previous reply why.

-- 
With Best Regards,
Andy Shevchenko