[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250811-k1-clk-i2s-generation-v2-0-e4d3ec268b7a@linux.spacemit.com>
Date: Mon, 11 Aug 2025 22:04:26 +0800
From: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
To: Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Yixun Lan <dlan@...too.org>,
Alex Elder <elder@...cstar.com>, Haylen Chu <heylenay@....org>,
Inochi Amaoto <inochiama@...look.com>
Cc: linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev,
linux-kernel@...r.kernel.org, Jinmei Wei <weijinmei@...ux.spacemit.com>,
Troy Mitchell <troy.mitchell@...ux.spacemit.com>
Subject: [PATCH v2 0/4] clk: spacemit: fix i2s clock
Previously, the driver defined two clocks for the I2S controller:
i2s_bclk and its parent i2s_sysclk.
Both i2s_bclk and i2s_sysclk were treated as fixed-factor clocks,
which clearly does not reflect the practical requirements for I2S operation.
Additionally, the original driver overlooked some upstream clock sources.
To fix the I2S clock, this series also introduces several new clock definition macros.
The I2S clock hierarchy can be found here [1].
Link:
https://developer.spacemit.com/documentation?token=LCrKwWDasiJuROkVNusc2pWTnEb
[1]
Signed-off-by: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
---
Changes in v2:
- change the macro for i2s_sysclk_src to CCU_MUX_GATE_DEFINE
- introduce factor for div clock
- modify commit messages
- remove CCU_DDN_GATE_DEFINE
- remove CCU_DIV_TABLE_GATE_DEFINE
- remove reformatting in k1-syscon.h
- split patch2/2 into separate patches
- Link to v1: https://lore.kernel.org/r/20250807-k1-clk-i2s-generation-v1-0-7dc25eb4e4d3@linux.spacemit.com
---
Troy Mitchell (4):
dt-bindings: clock: spacemit: introduce i2s pre-clock to fix i2s clock
clk: spacemit: introduce pre-div for ddn clock
clk: spacemit: introduce factor for div clock
clk: spacemit: fix i2s clock
drivers/clk/spacemit/ccu-k1.c | 28 +++++++++++++++++++++-----
drivers/clk/spacemit/ccu_ddn.c | 12 +++++------
drivers/clk/spacemit/ccu_ddn.h | 6 ++++--
drivers/clk/spacemit/ccu_mix.c | 7 ++++++-
drivers/clk/spacemit/ccu_mix.h | 4 +++-
include/dt-bindings/clock/spacemit,k1-syscon.h | 3 +++
include/soc/spacemit/k1-syscon.h | 1 +
7 files changed, 46 insertions(+), 15 deletions(-)
---
base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
change-id: 20250804-k1-clk-i2s-generation-eee7049ee17a
Best regards,
--
Troy Mitchell <troy.mitchell@...ux.spacemit.com>
Powered by blists - more mailing lists