linux-kernel - Re: [PATCH v2 1/5] iio: imu: inv_icm42600: Simplify pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vf-WGZ53Hj=QOgeft3oWYnO3kPFXsDSD0gaAqTNdciHfQ@mail.gmail.com>
Date: Mon, 11 Aug 2025 16:24:50 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Sean Nyekjaer <sean@...nix.com>
Cc: Jonathan Cameron <jic23@...nel.org>, 
	Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>, David Lechner <dlechner@...libre.com>, 
	Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Jean-Baptiste Maneyrol <jmaneyrol@...ensense.com>, Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v2 1/5] iio: imu: inv_icm42600: Simplify pm_runtime setup

On Mon, Aug 11, 2025 at 4:21 PM Sean Nyekjaer <sean@...nix.com> wrote:
> On Sat, Aug 09, 2025 at 10:27:52PM +0100, Andy Shevchenko wrote:
> > On Sat, Aug 9, 2025 at 8:06 PM Jonathan Cameron <jic23@...nel.org> wrote:
> > > On Fri, 8 Aug 2025 23:37:51 +0200
> > > Andy Shevchenko <andy.shevchenko@...il.com> wrote:
> > > > On Fri, Aug 8, 2025 at 5:58 PM Sean Nyekjaer <sean@...nix.com> wrote:

...

> > > > > +       struct device *dev = regmap_get_device(st->map);
> > > > >
> > > > > +       if (!pm_runtime_status_suspended(dev))
> > > > > +               regulator_disable(st->vddio_supply);


> Andy, when doing reviews please keep the function name, as it's much
> easier to add the changes.

Sure, sorry I missed it, I thought it was obvious, but you are right,
it's better to keep more context.

-- 
With Best Regards,
Andy Shevchenko