linux-kernel - Re: [patch V2 m@/6] perf/core: Split out mlock limit handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250811144047.GA4067720@noisy.programming.kicks-ass.net>
Date: Mon, 11 Aug 2025 16:40:47 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: LKML <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...uxfoundation.org>,
	Ingo Molnar <mingo@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	Kees Cook <kees@...nel.org>
Subject: Re: [patch V2 m@/6] perf/core: Split out mlock limit handling

On Mon, Aug 11, 2025 at 02:42:58PM +0200, Thomas Gleixner wrote:

> > Does this not also need this? I found this stray user_extra when I
> > eventually removed the local user_extra variable.
> >
> >
> > --- a/kernel/events/core.c
> > +++ b/kernel/events/core.c
> > @@ -6997,8 +6997,6 @@ static int perf_mmap(struct file *file,
> >  	if (vma_size != PAGE_SIZE * nr_pages)
> >  		return -EINVAL;
> >  
> > -	user_extra = nr_pages;
> > -
> >  	mutex_lock(&event->mmap_mutex);
> >  	ret = -EINVAL;
> >  
> 
> No. That's how user_extra is initialized in the first place.
> 
> To remove that nr_pages must become an argument to that function.

Ah, I see. Let me go fix that.