linux-kernel - Re: [PATCH] drm/gud: Remove unnecessary logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6a9b84ad-f2aa-4073-9318-8c2e6b2edb26@suse.de>
Date: Mon, 11 Aug 2025 17:15:55 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Ruben Wauters <rubenru09@....com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/gud: Remove unnecessary logging

Hi

Am 22.07.25 um 01:22 schrieb Ruben Wauters:

I've been on vacation, hence the delay.

> The debug logging in gud_disconnect() adds zero detail and is
> unnecessary, as it only prints the function name.
>
> The same functionality can be achieved by using ftrace, and is
> highlighted by checkpatch, stating the same.
>
> This patch removes the debug log in the gud_disconnect() function.
>
> Signed-off-by: Ruben Wauters <rubenru09@....com>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

Thanks for the patch. I'll add it to drm-misc-next.

Best regards
Thomas

> ---
>   drivers/gpu/drm/gud/gud_drv.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/gud/gud_drv.c b/drivers/gpu/drm/gud/gud_drv.c
> index 5385a2126e45..b52a12cbba3e 100644
> --- a/drivers/gpu/drm/gud/gud_drv.c
> +++ b/drivers/gpu/drm/gud/gud_drv.c
> @@ -620,8 +620,6 @@ static void gud_disconnect(struct usb_interface *interface)
>   	struct gud_device *gdrm = usb_get_intfdata(interface);
>   	struct drm_device *drm = &gdrm->drm;
>   
> -	drm_dbg(drm, "%s:\n", __func__);
> -
>   	drm_kms_helper_poll_fini(drm);
>   	drm_dev_unplug(drm);
>   	drm_atomic_helper_shutdown(drm);

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)