linux-kernel - RE: [Intel-wired-lan] [PATCH] igb: Fix NULL pointer dereference in ethtool loopback test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986B7279E3687E153559CC9E528A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Mon, 11 Aug 2025 15:45:48 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Tianyu Xu <xtydtc@...il.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>
CC: "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "kuba@...nel.org"
	<kuba@...nel.org>, "sdf@...ichev.me" <sdf@...ichev.me>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tianyxu@...co.com" <tianyxu@...co.com>
Subject: RE: [Intel-wired-lan] [PATCH] igb: Fix NULL pointer dereference in
 ethtool loopback test



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Tianyu Xu
> Sent: Monday, August 11, 2025 1:42 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>
> Cc: Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>;
> andrew+netdev@...n.ch; kuba@...nel.org; sdf@...ichev.me; intel-wired-
> lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; tianyxu@...co.com
> Subject: [Intel-wired-lan] [PATCH] igb: Fix NULL pointer dereference
> in ethtool loopback test
> 
> The igb driver currently causes a NULL pointer dereference
> when executing the ethtool loopback test. This occurs because
> there is no associated q_vector for the test ring when it is
> set up, as interrupts are typically not added to the test rings.
> 
> Since commit 5ef44b3cb43b removed the napi_id assignment in
> __xdp_rxq_info_reg(), there is no longer a need to pass a napi_id.
> Therefore, simply use 0 as the final parameter.
> 
Good day,  Tianyu Xu,

Thanks for the patch. I've reviewed the commit message and have a few minor suggestions to align it with kernel style guidelines:

Can you consider wrapping body lines at 75 characters for better readability?
If applicable, please include Fixes: tag in the commit message. This helps maintainers and automated tools track regressions and understand the context of the fix. Other than that, the change itself looks good and clearly improves the accuracy of statistics reporting.

Best regards,
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>

> Signed-off-by: Tianyu Xu <tianyxu@...co.com>
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
> b/drivers/net/ethernet/intel/igb/igb_main.c
> index a9a7a94ae..453deb6d1 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -4453,8 +4453,7 @@ int igb_setup_rx_resources(struct igb_ring
> *rx_ring)
>  	if (xdp_rxq_info_is_reg(&rx_ring->xdp_rxq))
>  		xdp_rxq_info_unreg(&rx_ring->xdp_rxq);
>  	res = xdp_rxq_info_reg(&rx_ring->xdp_rxq, rx_ring->netdev,
> -			       rx_ring->queue_index,
> -			       rx_ring->q_vector->napi.napi_id);
> +			       rx_ring->queue_index, 0);
>  	if (res < 0) {
>  		dev_err(dev, "Failed to register xdp_rxq index %u\n",
>  			rx_ring->queue_index);
> --
> 2.39.5 (Apple Git-154)