Message-ID: <d3b0ae61d0bb5dc4e115ace27e1672444ae90d83.camel@gmail.com>
Date: Mon, 11 Aug 2025 17:50:46 +0200
From: Alexander Sverdlin <alexander.sverdlin@...il.com>
To: bmasney@...hat.com, Michael Turquette <mturquette@...libre.com>, Stephen
 Boyd <sboyd@...nel.org>, Sudeep Holla <sudeep.holla@....com>, Cristian
 Marussi	 <cristian.marussi@....com>, Chen Wang <unicorn_wang@...look.com>,
 Inochi Amaoto	 <inochiama@...il.com>, Nicolas Ferre
 <nicolas.ferre@...rochip.com>,  Alexandre Belloni
 <alexandre.belloni@...tlin.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
 Paul Cercueil	 <paul@...pouillou.net>, Keguang Zhang
 <keguang.zhang@...il.com>, Taichi Sugaya	 <sugaya.taichi@...ionext.com>,
 Takao Orito <orito.takao@...ionext.com>,  Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team	
 <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Jacky Huang	
 <ychuang3@...oton.com>, Shan-Chun Hung <schung@...oton.com>, Vladimir
 Zapolskiy	 <vz@...ia.com>, Piotr Wojtaszczyk
 <piotr.wojtaszczyk@...esys.com>, Paul Walmsley <paul.walmsley@...ive.com>,
 Samuel Holland <samuel.holland@...ive.com>, Yixun Lan	 <dlan@...too.org>,
 Steen Hegelund <Steen.Hegelund@...rochip.com>, Daniel Machon	
 <daniel.machon@...rochip.com>, UNGLinuxDriver@...rochip.com, Orson Zhai	
 <orsonzhai@...il.com>, Baolin Wang <baolin.wang@...ux.alibaba.com>, Chunyan
 Zhang <zhang.lyra@...il.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue	 <alexandre.torgue@...s.st.com>, Michal Simek
 <michal.simek@....com>, Maxime Ripard <mripard@...nel.org>, Andreas
 Färber <afaerber@...e.de>,  Manivannan Sadhasivam	
 <mani@...nel.org>, Sven Peter <sven@...nel.org>, Janne Grunau
 <j@...nau.net>,  Alyssa Rosenzweig <alyssa@...enzweig.io>, Neal Gompa
 <neal@...pa.dev>, Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,  Ray Jui
 <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, Broadcom
 internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Max
 Filippov <jcmvbkbc@...il.com>, Matthias Brugger	 <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno	 <angelogioacchino.delregno@...labora.com>,
 Daniel Palmer <daniel@...ngy.jp>,  Romain Perier <romain.perier@...il.com>,
 Andrew Lunn <andrew@...n.ch>, Gregory Clement	
 <gregory.clement@...tlin.com>, Sebastian Hesselbarth	
 <sebastian.hesselbarth@...il.com>, Bjorn Andersson <andersson@...nel.org>, 
 Geert Uytterhoeven <geert+renesas@...der.be>, Heiko Stuebner
 <heiko@...ech.de>, Andrea della Porta <andrea.porta@...e.com>,  Krzysztof
 Kozlowski	 <krzk@...nel.org>, Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Chanwoo Choi	 <cw00.choi@...sung.com>, Alim Akhtar
 <alim.akhtar@...sung.com>, Qin Jian	 <qinjian@...lus1.com>, Viresh Kumar
 <vireshk@...nel.org>, Ulf Hansson	 <ulf.hansson@...aro.org>, Luca Ceresoli
 <luca.ceresoli@...tlin.com>, Alex Helms	 <alexander.helms.jy@...esas.com>,
 Linus Walleij <linus.walleij@...aro.org>,  Liviu Dudau
 <liviu.dudau@....com>, Lorenzo Pieralisi <lpieralisi@...nel.org>, Nobuhiro
 Iwamatsu	 <nobuhiro1.iwamatsu@...hiba.co.jp>
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, 
	arm-scmi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	sophgo@...ts.linux.dev, linux-mips@...r.kernel.org, imx@...ts.linux.dev, 
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev, 
	linux-stm32@...md-mailman.stormreply.com, patches@...nsource.cirrus.com, 
	linux-actions@...ts.infradead.org, asahi@...ts.linux.dev, 
	linux-mediatek@...ts.infradead.org, linux-arm-msm@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org, linux-rockchip@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, soc@...ts.linux.dev
Subject: Re: [PATCH 014/114] clk: ep93xx: convert from round_rate() to
 determine_rate()

On Mon, 2025-08-11 at 11:18 -0400, Brian Masney via B4 Relay wrote:
> From: Brian Masney <bmasney@...hat.com>
> 
> The round_rate() clk ops is deprecated, so migrate this driver from
> round_rate() to determine_rate() using the Coccinelle semantic patch
> on the cover letter of this series.
> 
> Signed-off-by: Brian Masney <bmasney@...hat.com>

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...il.com>

> ---
>  drivers/clk/clk-ep93xx.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/clk/clk-ep93xx.c b/drivers/clk/clk-ep93xx.c
> index 4bd8d6ecf6a2bde26287e4e949b062a5660139e6..b081ef920e250dd99134af6845c443ee11266da8 100644
> --- a/drivers/clk/clk-ep93xx.c
> +++ b/drivers/clk/clk-ep93xx.c
> @@ -389,23 +389,25 @@ static unsigned long ep93xx_div_recalc_rate(struct clk_hw *hw,
>  	return DIV_ROUND_CLOSEST(parent_rate, clk->div[index]);
>  }
>  
> -static long ep93xx_div_round_rate(struct clk_hw *hw, unsigned long rate,
> -				   unsigned long *parent_rate)
> +static int ep93xx_div_determine_rate(struct clk_hw *hw,
> +				     struct clk_rate_request *req)
>  {
>  	struct ep93xx_clk *clk = ep93xx_clk_from(hw);
>  	unsigned long best = 0, now;
>  	unsigned int i;
>  
>  	for (i = 0; i < clk->num_div; i++) {
> -		if ((rate * clk->div[i]) == *parent_rate)
> -			return rate;
> +		if (req->rate * clk->div[i] == req->best_parent_rate)
> +			return 0;
>  
> -		now = DIV_ROUND_CLOSEST(*parent_rate, clk->div[i]);
> -		if (!best || is_best(rate, now, best))
> +		now = DIV_ROUND_CLOSEST(req->best_parent_rate, clk->div[i]);
> +		if (!best || is_best(req->rate, now, best))
>  			best = now;
>  	}
>  
> -	return best;
> +	req->rate = best;
> +
> +	return 0;
>  }
>  
>  static int ep93xx_div_set_rate(struct clk_hw *hw, unsigned long rate,
> @@ -437,7 +439,7 @@ static const struct clk_ops ep93xx_div_ops = {
>  	.disable = ep93xx_clk_disable,
>  	.is_enabled = ep93xx_clk_is_enabled,
>  	.recalc_rate = ep93xx_div_recalc_rate,
> -	.round_rate = ep93xx_div_round_rate,
> +	.determine_rate = ep93xx_div_determine_rate,
>  	.set_rate = ep93xx_div_set_rate,
>  };

-- 
Alexander Sverdlin.

Powered by blists - more mailing lists