linux-kernel - Re: [PATCH 001/114] clk: at91: peripheral: fix return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <522ae36bf788df6d957bfee671857d6b2e1e8863.camel@gmail.com>
Date: Mon, 11 Aug 2025 17:59:22 +0200
From: Alexander Sverdlin <alexander.sverdlin@...il.com>
To: bmasney@...hat.com, Michael Turquette <mturquette@...libre.com>, Stephen
 Boyd <sboyd@...nel.org>, Sudeep Holla <sudeep.holla@....com>, Cristian
 Marussi	 <cristian.marussi@....com>, Chen Wang <unicorn_wang@...look.com>,
 Inochi Amaoto	 <inochiama@...il.com>, Nicolas Ferre
 <nicolas.ferre@...rochip.com>,  Alexandre Belloni
 <alexandre.belloni@...tlin.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
 Paul Cercueil	 <paul@...pouillou.net>, Keguang Zhang
 <keguang.zhang@...il.com>, Taichi Sugaya	 <sugaya.taichi@...ionext.com>,
 Takao Orito <orito.takao@...ionext.com>,  Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team	
 <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Jacky Huang	
 <ychuang3@...oton.com>, Shan-Chun Hung <schung@...oton.com>, Vladimir
 Zapolskiy	 <vz@...ia.com>, Piotr Wojtaszczyk
 <piotr.wojtaszczyk@...esys.com>, Paul Walmsley <paul.walmsley@...ive.com>,
 Samuel Holland <samuel.holland@...ive.com>, Yixun Lan	 <dlan@...too.org>,
 Steen Hegelund <Steen.Hegelund@...rochip.com>, Daniel Machon	
 <daniel.machon@...rochip.com>, UNGLinuxDriver@...rochip.com, Orson Zhai	
 <orsonzhai@...il.com>, Baolin Wang <baolin.wang@...ux.alibaba.com>, Chunyan
 Zhang <zhang.lyra@...il.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue	 <alexandre.torgue@...s.st.com>, Michal Simek
 <michal.simek@....com>, Maxime Ripard <mripard@...nel.org>, Andreas
 Färber <afaerber@...e.de>,  Manivannan Sadhasivam	
 <mani@...nel.org>, Sven Peter <sven@...nel.org>, Janne Grunau
 <j@...nau.net>,  Alyssa Rosenzweig <alyssa@...enzweig.io>, Neal Gompa
 <neal@...pa.dev>, Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,  Ray Jui
 <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, Broadcom
 internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Max
 Filippov <jcmvbkbc@...il.com>, Matthias Brugger	 <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno	 <angelogioacchino.delregno@...labora.com>,
 Daniel Palmer <daniel@...ngy.jp>,  Romain Perier <romain.perier@...il.com>,
 Andrew Lunn <andrew@...n.ch>, Gregory Clement	
 <gregory.clement@...tlin.com>, Sebastian Hesselbarth	
 <sebastian.hesselbarth@...il.com>, Bjorn Andersson <andersson@...nel.org>, 
 Geert Uytterhoeven <geert+renesas@...der.be>, Heiko Stuebner
 <heiko@...ech.de>, Andrea della Porta <andrea.porta@...e.com>,  Krzysztof
 Kozlowski	 <krzk@...nel.org>, Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Chanwoo Choi	 <cw00.choi@...sung.com>, Alim Akhtar
 <alim.akhtar@...sung.com>, Qin Jian	 <qinjian@...lus1.com>, Viresh Kumar
 <vireshk@...nel.org>, Ulf Hansson	 <ulf.hansson@...aro.org>, Luca Ceresoli
 <luca.ceresoli@...tlin.com>, Alex Helms	 <alexander.helms.jy@...esas.com>,
 Linus Walleij <linus.walleij@...aro.org>,  Liviu Dudau
 <liviu.dudau@....com>, Lorenzo Pieralisi <lpieralisi@...nel.org>, Nobuhiro
 Iwamatsu	 <nobuhiro1.iwamatsu@...hiba.co.jp>
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, 
	arm-scmi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	sophgo@...ts.linux.dev, linux-mips@...r.kernel.org, imx@...ts.linux.dev, 
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev, 
	linux-stm32@...md-mailman.stormreply.com, patches@...nsource.cirrus.com, 
	linux-actions@...ts.infradead.org, asahi@...ts.linux.dev, 
	linux-mediatek@...ts.infradead.org, linux-arm-msm@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org, linux-rockchip@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, soc@...ts.linux.dev
Subject: Re: [PATCH 001/114] clk: at91: peripheral: fix return value

On Mon, 2025-08-11 at 11:17 -0400, Brian Masney via B4 Relay wrote:
> From: Brian Masney <bmasney@...hat.com>
> 
> determine_rate() is expected to return an error code, or 0 on success.
> clk_sam9x5_peripheral_determine_rate() has a branch that returns the
> parent rate on a certain case. This is the behavior of round_rate(),
> so let's go ahead and fix this by setting req->rate.
> 
> Fixes: b4c115c76184f ("clk: at91: clk-peripheral: add support for changeable parent rate")
> Signed-off-by: Brian Masney <bmasney@...hat.com>

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...il.com>

> ---
>  drivers/clk/at91/clk-peripheral.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/at91/clk-peripheral.c b/drivers/clk/at91/clk-peripheral.c
> index c173a44c800aa8cc6970c266995f4a60b0a38554..629f050a855aaebfd1a03ff87c2b016cd2284a5a 100644
> --- a/drivers/clk/at91/clk-peripheral.c
> +++ b/drivers/clk/at91/clk-peripheral.c
> @@ -279,8 +279,11 @@ static int clk_sam9x5_peripheral_determine_rate(struct clk_hw *hw,
>  	long best_diff = LONG_MIN;
>  	u32 shift;
>  
> -	if (periph->id < PERIPHERAL_ID_MIN || !periph->range.max)
> -		return parent_rate;
> +	if (periph->id < PERIPHERAL_ID_MIN || !periph->range.max) {
> +		req->rate = parent_rate;
> +
> +		return 0;
> +	}
>  
>  	/* Fist step: check the available dividers. */
>  	for (shift = 0; shift <= PERIPHERAL_MAX_SHIFT; shift++) {

-- 
Alexander Sverdlin.