linux-kernel - Re: [PATCH 2/4] fscrypto: Remove redundant __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250811173103.GC1268@sol>
Date: Mon, 11 Aug 2025 10:31:03 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: Qianfeng Rong <rongqianfeng@...o.com>
Cc: "Theodore Y. Ts'o" <tytso@....edu>, Jaegeuk Kim <jaegeuk@...nel.org>,
	"open list:FSCRYPT: FILE SYSTEM LEVEL ENCRYPTION SUPPORT" <linux-fscrypt@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, willy@...radead.org
Subject: Re: [PATCH 2/4] fscrypto: Remove redundant __GFP_NOWARN

On Sun, Aug 03, 2025 at 06:22:40PM +0800, Qianfeng Rong wrote:
> GFP_NOWAIT already includes __GFP_NOWARN, so let's remove
> the redundant __GFP_NOWARN.
> 
> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
> ---
>  fs/crypto/bio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/crypto/bio.c b/fs/crypto/bio.c
> index 486fcb2ecf13..e92967e20e2a 100644
> --- a/fs/crypto/bio.c
> +++ b/fs/crypto/bio.c
> @@ -148,7 +148,7 @@ int fscrypt_zeroout_range(const struct inode *inode, pgoff_t lblk,
>  	 */
>  	for (i = 0; i < nr_pages; i++) {
>  		pages[i] = fscrypt_alloc_bounce_page(i == 0 ? GFP_NOFS :
> -						     GFP_NOWAIT | __GFP_NOWARN);
> +						     GFP_NOWAIT);
>  		if (!pages[i])
>  			break;
>  	}
> -- 
> 2.34.1
> 

Applied to https://git.kernel.org/pub/scm/fs/fscrypt/linux.git/log/?h=for-next

Thanks!

- Eric