linux-kernel - Re: [PATCH] mm/vmscan: remove redundant folio_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAG18JnyyyReXCKRhoF86DhAWDa1-jhdHULdFKULdRRLSs7QKKA@mail.gmail.com>
Date: Tue, 12 Aug 2025 02:36:32 +0800
From: Jialin Wang <wjl.linux@...il.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/vmscan: remove redundant folio_test_swapbacked()

On Tue, Aug 12, 2025 at 2:18 AM Jialin Wang <wjl.linux@...il.com> wrote:
>
> When !folio_is_file_lru(folio) is false, it implies that
> !folio_test_swapbacked(folio) must be true. Therefore, the additional
> check for !folio_test_swapbacked(folio) is redundant and can be safely
> removed.
>
> This cleanup simplifies the code without changing any functionality.
>
> Signed-off-by: Jialin Wang <wjl.linux@...il.com>
> ---
>  mm/vmscan.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 7de11524a936..9d4745ad5e23 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -985,8 +985,7 @@ static void folio_check_dirty_writeback(struct folio *folio,
>          * They could be mistakenly treated as file lru. So further anon
>          * test is needed.
>          */
> -       if (!folio_is_file_lru(folio) ||
> -           (folio_test_anon(folio) && !folio_test_swapbacked(folio))) {
> +       if (!folio_is_file_lru(folio) || folio_test_anon(folio)) {
>                 *dirty = false;
>                 *writeback = false;
>                 return;
> --
> 2.50.0
>

My apologies for sending this patch to the wrong mailing list and
missing proper cc's. Please disregard this patch as I've now
resent it correctly.

  https://lore.kernel.org/linux-mm/20250811182500.42670-1-wjl.linux@gmail.com/

Thank you for your understanding, and sorry for the noise.

Best regards,
Jialin Wang