linux-kernel - Re: [PATCH v5 1/2] dt-bindings: i2c: qcom-cci: Document QCM2290 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4bldj7jjsi4o2wz4wij2ggog4no2nndavk4r7frvd6fv5fjtfn@4unsvlv2mdl7>
Date: Mon, 11 Aug 2025 14:46:39 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Loic Poulain <loic.poulain@....qualcomm.com>, andi.shyti@...nel.org
Cc: rfoss@...nel.org, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, konradybcio@...nel.org, linux-i2c@...r.kernel.org, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v5 1/2] dt-bindings: i2c: qcom-cci: Document QCM2290
 compatible

On Mon, May 19, 2025 at 11:47:44AM +0200, Loic Poulain wrote:
> The CCI on QCM2290 is the interface for controlling camera sensor over I2C.
> It requires only two clocks.
> 
> Signed-off-by: Loic Poulain <loic.poulain@....qualcomm.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Reviewed-by: Bjorn Andersson <andersson@...nel.org>

Andi, can you please pick this binding, so I can pick the dts change?

Regards,
Bjorn

> ---
>  v2: Reorder commits and Fix binding testing syntax
>  v3: Add clocks minItems for msm8974 as top-level minItems changed
>  v4: change AHB clock name from camss_top_ahb to ahb
>  v5: No change; Resent with missing recipients
> 
>  .../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 22 +++++++++++++++++--
>  1 file changed, 20 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> index 73144473b9b2..83b13370ff6c 100644
> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> @@ -25,6 +25,7 @@ properties:
>  
>        - items:
>            - enum:
> +              - qcom,qcm2290-cci
>                - qcom,sc7280-cci
>                - qcom,sc8280xp-cci
>                - qcom,sdm670-cci
> @@ -44,11 +45,11 @@ properties:
>      const: 0
>  
>    clocks:
> -    minItems: 3
> +    minItems: 2
>      maxItems: 6
>  
>    clock-names:
> -    minItems: 3
> +    minItems: 2
>      maxItems: 6
>  
>    interrupts:
> @@ -113,6 +114,7 @@ allOf:
>      then:
>        properties:
>          clocks:
> +          minItems: 3
>            maxItems: 3
>          clock-names:
>            items:
> @@ -120,6 +122,22 @@ allOf:
>              - const: cci_ahb
>              - const: cci
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - qcom,qcm2290-cci
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 2
> +          maxItems: 2
> +        clock-names:
> +          items:
> +            - const: ahb
> +            - const: cci
> +
>    - if:
>        properties:
>          compatible:
> -- 
> 2.34.1
>