Message-Id: <20250811-ap1302-v4-1-80cc41b91662@nxp.com>
Date: Mon, 11 Aug 2025 16:42:30 -0400
From: Frank Li <Frank.Li@....com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>, 
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Conor Dooley <conor+dt@...nel.org>, Kumar M <anil.mamidala@...inx.com>
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org, 
 linux-kernel@...r.kernel.org, imx@...ts.linux.dev, 
 "Guoniu.zhou" <guoniu.zhou@....com>, Frank Li <Frank.Li@....com>, 
 Stefan Hladnik <stefan.hladnik@...il.com>, 
 Florian Rebaudo <frebaudo@...ekio.com>
Subject: [PATCH v4 1/2] dt-bindings: media: i2c: Add bindings for AP1302

From: Anil Kumar Mamidala <anil.mamidala@...inx.com>

The AP1302 is a standalone ISP for ON Semiconductor sensors, which can
connect RAW sensors (AR0144).

Add corresponding DT bindings.

Signed-off-by: Anil Kumar Mamidala <anil.mamidala@...inx.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Signed-off-by: Stefan Hladnik <stefan.hladnik@...il.com>
Signed-off-by: Florian Rebaudo <frebaudo@...ekio.com>
Signed-off-by: Frank Li <Frank.Li@....com>
---
Previous try:
https://lore.kernel.org/linux-media/1631091372-16191-2-git-send-email-anil.mamidala@xilinx.com/

Change in v4:
- base on discussion https://lore.kernel.org/imx/CAL_JsqLUj2h1OxUokOGFL34czroJnJ33cpvn9jO8b8=cu8Fz0g@mail.gmail.com/
  change to use onnn,model property to descript connected raw sensor
- Overall roll back to v2, move raw sensor information under "sensor" from
  ports.
- regs use enum [0, 1] to restrict address range
- add supply name from sensor

Change in v3:
- Move sensors under ports
- use compatible string to indentify connected raw sensors
- Add onnn,ar0144.yaml
---
 .../devicetree/bindings/media/i2c/onnn,ap1302.yaml | 184 +++++++++++++++++++++
 MAINTAINERS                                        |   8 +
 2 files changed, 192 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,ap1302.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,ap1302.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..d66962d2eadca3f4d86c99a68d5ae7996bd1a522
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/onnn,ap1302.yaml
@@ -0,0 +1,184 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/onnn,ap1302.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ON Semiconductor AP1302 Advanced Image Coprocessor
+
+maintainers:
+  - Laurent Pinchart <laurent.pinchart@...asonboard.com>
+  - Frank Li <Frank.Li@....com>
+
+description:
+  The AP1302 is a standalone ISP for ON Semiconductor sensors. It interfaces to
+  up to two RAW CMOS sensors over MIPI CSI-2 connections, processes the two
+  video streams and outputs YUV frames to the host over a MIPI CSI-2 interface.
+  Frames are output side by side or on two virtual channels.
+
+  The sensors must be identical. They are connected to the AP1302 on dedicated
+  I2C buses, and are controlled by the AP1302 firmware. They are not accessible
+  from the host.
+
+properties:
+  compatible:
+    const: onnn,ap1302
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description:
+          Reference to the CLK clock.
+
+  enable-gpios:
+    items:
+      - description:
+          Reference to the GPIO connected to the EN pin (active high).
+
+  reset-gpios:
+    items:
+      - description:
+          Reference to the GPIO connected to the RST pin (active low).
+
+  standby-gpios:
+    items:
+      - description:
+          Reference to the GPIO connected to the STANDBY pin (active high).
+
+  dvdd-supply: true
+
+  hmisc-supply: true
+
+  smisc-supply: true
+
+  port:
+    $ref: /schemas/graph.yaml#/$defs/port-base
+    unevaluatedProperties: false
+    description: MIPI CSI-2 output interface to the host.
+
+    properties:
+      endpoint:
+        $ref: /schemas/media/video-interfaces.yaml#
+        unevaluatedProperties: false
+
+        properties:
+          data-lanes:
+            oneOf:
+              - items:
+                  - const: 1
+              - items:
+                  - const: 1
+                  - const: 2
+              - items:
+                  - const: 1
+                  - const: 2
+                  - const: 3
+                  - const: 4
+
+        required:
+          - data-lanes
+
+  sensors:
+    type: object
+    additionalProperties: false
+    description: List of connected sensors
+
+    properties:
+      "#address-cells":
+        const: 1
+
+      "#size-cells":
+        const: 0
+
+      onnn,model:
+        enum:
+          - onnn,ar0144
+          - onnn,ar0330
+          - onnn,ar1335
+        description:
+          Model of the connected sensors. Must be a valid compatible string.
+
+          If no sensor is connected, this property must no be specified, and
+          the AP1302 can be used with it's internal test pattern generator.
+
+    patternProperties:
+      "^sensor@[01]":
+        type: object
+        additionalProperties: false
+        description:
+          Sensors connected to the first and second input, with one node per
+          sensor.
+
+        properties:
+          reg:
+            description: AP1302 input port number
+            items:
+              - enum: [0, 1]
+
+          vaa-supply: true
+
+          vdd-supply: true
+
+          vddio-supply: true
+
+          vddpll-supply: true
+
+        required:
+          - reg
+
+    required:
+      - "#address-cells"
+      - "#size-cells"
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - port
+  - sensors
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        camera@3c {
+            compatible = "onnn,ap1302";
+            reg = <0x3c>;
+
+            clocks = <&clk24mhz>;
+
+            reset-gpios = <&pio 102 GPIO_ACTIVE_LOW>;
+            standby-gpios = <&pio 40 GPIO_ACTIVE_HIGH>;
+
+            port {
+                isp1_out: endpoint {
+                    remote-endpoint = <&seninf_in1>;
+                    data-lanes = <1 2 3 4>;
+                };
+            };
+
+            sensors {
+                #address-cells = <1>;
+                #size-cells = <0>;
+
+                onnn,model = "onnn,ar0144";
+
+                sensor@0 {
+                    reg = <0>;
+
+                    vdd-supply = <&mt6358_vcamd_reg>;
+                    vaa-supply = <&mt6358_vcama1_reg>;
+                    vddio-supply = <&reg_1p8v_ext>;
+                };
+            };
+        };
+    };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index fb578b329b72f8765b856e39e9633c1ff90cc0a4..fb2bcd73117d5bbc9fc33355cc86f945da1ce48f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1811,6 +1811,14 @@ L:	linux-sound@...r.kernel.org
 S:	Maintained
 F:	sound/aoa/
 
+AP1302 ON SEMICONDUCTOR ISP DRIVER
+M:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
+R:	Frank Li <Frank.Li@....com>
+L:	linux-media@...r.kernel.org
+S:	Maintained
+T:	git git://linuxtv.org/media.git
+F:	Documentation/devicetree/bindings/media/i2c/onnn,ap1302.yaml
+
 APEX EMBEDDED SYSTEMS STX104 IIO DRIVER
 M:	William Breathitt Gray <wbg@...nel.org>
 L:	linux-iio@...r.kernel.org

-- 
2.34.1

Powered by blists - more mailing lists