linux-kernel - Re: [PATCH v2] platform/x86: Add WMI driver for Redmibook keyboard.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250811212353.4494-1-foxido@foxido.dev>
Date: Tue, 12 Aug 2025 00:23:53 +0300
From: foxidokun <foxido@...ido.dev>
To: dmitry.torokhov@...il.com
Cc: foxido@...ido.dev,
	hansg@...nel.org,
	ilpo.jarvinen@...ux.intel.com,
	linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	nikita.nikita.krasnov@...il.com,
	platform-driver-x86@...r.kernel.org,
	w_armin@....de
Subject: Re: [PATCH v2] platform/x86: Add WMI driver for Redmibook keyboard.

> > +	/* For linearizability */
> > +	guard(mutex)(&data->key_lock);
>
> What is the exact purpose of this mutex? What does it protect? 

It protects key sequence, so there wouldn't be race between two press & release combinations resuulting into press - press - release - release order.

--
Gladyshev Ilya