linux-kernel - RE: [PATCH 0/3] net/ceph/messenger: micro-optimizations for out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <313a950008c144541dc8c4685c4f9682c476fbdd.camel@ibm.com>
Date: Mon, 11 Aug 2025 23:27:30 +0000
From: Viacheslav Dubeyko <Slava.Dubeyko@....com>
To: Alex Markuze <amarkuze@...hat.com>,
        "max.kellermann@...os.com"
	<max.kellermann@...os.com>,
        "ceph-devel@...r.kernel.org"
	<ceph-devel@...r.kernel.org>,
        Xiubo Li <xiubli@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "idryomov@...il.com" <idryomov@...il.com>
Subject: RE:  [PATCH 0/3] net/ceph/messenger: micro-optimizations for out_msg

On Mon, 2025-08-11 at 17:05 +0000, Viacheslav Dubeyko wrote:
> On Wed, 2025-08-06 at 11:48 +0200, Max Kellermann wrote:
> > These patches reduce reloads of con->out_msg by passing pointers that
> > we already have in local variables (i.e. registers) as parameters.
> > 
> > Access to con->out_queue is now gone completely from v1/v2 and only
> > few references to con->out_msg remain.  In the long run, I'd like to
> > get rid of con->out_msg completely and instead send the whole
> > con->out_queue in one kernel_sendmsg() call.  This patch series helps
> > with preparing that.
> > 
> > Max Kellermann (3):
> >   net/ceph/messenger: ceph_con_get_out_msg() returns the message pointer
> >   net/ceph/messenger_v[12]: pass ceph_msg* instead of loading
> >     con->out_msg
> >   net/ceph/messenger: add empty check to ceph_con_get_out_msg()
> > 
> >  include/linux/ceph/messenger.h |   6 +-
> >  net/ceph/messenger.c           |  12 +--
> >  net/ceph/messenger_v1.c        |  59 ++++++------
> >  net/ceph/messenger_v2.c        | 160 ++++++++++++++++-----------------
> >  4 files changed, 119 insertions(+), 118 deletions(-)
> 
> Unexpectedly, I can see xfstests failures with applied patchset:
> 
> Failures: generic/633 generic/644 generic/645 generic/689 generic/696
> generic/697
> Failed 6 of 610 tests
> 
> I will repeat xfestests run with and without patchset. Maybe, it is the glitch
> on my side.
> 
> 

I double checked the xfstests run. Everything works well. It was glitch on my
side.

Thanks,
Slava.