linux-kernel - Re: [PATCH v2 1/3] mm/huge_memory: add new_order and offset to split_huge_pages*() pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGsJ_4y23gxB+P8=WkBe+oU9j+1YDZmBUTdE2=aw40O78DA7Yg@mail.gmail.com>
Date: Mon, 11 Aug 2025 14:58:58 +0800
From: Barry Song <21cnbao@...il.com>
To: Zi Yan <ziy@...dia.com>
Cc: Wei Yang <richard.weiyang@...il.com>, wang lian <lianux.mm@...il.com>, 
	Baolin Wang <baolin.wang@...ux.alibaba.com>, David Hildenbrand <david@...hat.com>, linux-mm@...ck.org, 
	Andrew Morton <akpm@...ux-foundation.org>, Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, 
	"Liam R. Howlett" <Liam.Howlett@...cle.com>, Nico Pache <npache@...hat.com>, 
	Ryan Roberts <ryan.roberts@....com>, Dev Jain <dev.jain@....com>, 
	Vlastimil Babka <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>, Suren Baghdasaryan <surenb@...gle.com>, 
	Michal Hocko <mhocko@...e.com>, Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v2 1/3] mm/huge_memory: add new_order and offset to
 split_huge_pages*() pr_debug.

On Sat, Aug 9, 2025 at 3:02 AM Zi Yan <ziy@...dia.com> wrote:
>
> They are useful information for debugging split huge page tests.
>
> Signed-off-by: Zi Yan <ziy@...dia.com>

LGTM.
Reviewed-by: Barry Song <baohua@...nel.org>

> ---
>  mm/huge_memory.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 2b4ea5a2ce7d..ebf875928bac 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -4327,8 +4327,8 @@ static int split_huge_pages_pid(int pid, unsigned long vaddr_start,
>                 goto out;
>         }
>
> -       pr_debug("Split huge pages in pid: %d, vaddr: [0x%lx - 0x%lx]\n",
> -                pid, vaddr_start, vaddr_end);
> +       pr_debug("Split huge pages in pid: %d, vaddr: [0x%lx - 0x%lx], new_order: %u, in_folio_offset: %ld\n",
> +                pid, vaddr_start, vaddr_end, new_order, in_folio_offset);
>
>         mmap_read_lock(mm);
>         /*
> @@ -4438,8 +4438,8 @@ static int split_huge_pages_in_file(const char *file_path, pgoff_t off_start,
>         if (IS_ERR(candidate))
>                 goto out;
>
> -       pr_debug("split file-backed THPs in file: %s, page offset: [0x%lx - 0x%lx]\n",
> -                file_path, off_start, off_end);
> +       pr_debug("split file-backed THPs in file: %s, page offset: [0x%lx - 0x%lx], new_order: %u, in_folio_offset: %ld\n",
> +                file_path, off_start, off_end, new_order, in_folio_offset);
>
>         mapping = candidate->f_mapping;
>         min_order = mapping_min_folio_order(mapping);
> --
> 2.47.2
>

Thanks
Barry