linux-kernel - Re: [PATCH 02/11] staging: rtl8723bs: Reformat code to respect 100-column line limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJmcA7SlCjXXPsOl@stanley.mountain>
Date: Mon, 11 Aug 2025 10:30:11 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Yao-Wen Chang <changyaowen19980629@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/11] staging: rtl8723bs: Reformat code to respect
 100-column line limit

On Mon, Aug 11, 2025 at 02:21:25PM +0800, Yao-Wen Chang wrote:
> This commit breaks several long lines of code to ensure they do not exceed
> the 100-character limit.
> 
> Signed-off-by: Yao-Wen Chang <changyaowen19980629@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ap.c  |  12 ++-
>  drivers/staging/rtl8723bs/core/rtw_cmd.c | 106 ++++++++++++++++-------
>  2 files changed, 83 insertions(+), 35 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 47c63177b2a6..2e59a26e6318 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -391,7 +391,9 @@ void update_bmc_sta(struct adapter *padapter)
>  
>  		memset((void *)&psta->sta_stats, 0, sizeof(struct stainfo_stats));
>  
> -		/* psta->dot118021XPrivacy = _NO_PRIVACY_;//!!! remove it, because it has been set before this. */
> +		/* psta->dot118021XPrivacy = _NO_PRIVACY_;
> +		 * //!!! remove it, because it has been set before this.
> +		 */

Delete commented out code.  Also what the heck is up with "* //!!! remove it, ".

>  
>  		/* prepare for add_RATid */
>  		supportRateNum = rtw_get_rateset_len((u8 *)&pcur_network->supported_rates);
> @@ -841,7 +843,9 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
>  	memcpy(pbss_network->mac_address, myid(&padapter->eeprompriv), ETH_ALEN);
>  
>  	/* beacon interval */
> -	p = rtw_get_beacon_interval_from_ie(ie);/* ie + 8;	8: TimeStamp, 2: Beacon Interval 2:Capability */
> +	p = rtw_get_beacon_interval_from_ie(ie); /* ie + 8; 8:
> +						  *TimeStamp, 2: Beacon Interval 2:Capability
> +						  */

This is whack.  Just go through the rest of the patchset and really
think about things a little bit more carefully.  We could obviously
have fixed all the checkpatch patches automatically and there is a
checkpatch option to do that, but we want people to do it manually
and really review things in context.

regards,
dan carpenter