linux-kernel - [PATCH] coredump: simplify coredump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250811075155.7637-1-wangfushuai@baidu.com>
Date: Mon, 11 Aug 2025 15:51:55 +0800
From: Fushuai Wang <wangfushuai@...du.com>
To: <linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>
CC: <viro@...iv.linux.org.uk>, <brauner@...nel.org>, <jack@...e.cz>, Fushuai
 Wang <wangfushuai@...du.com>
Subject: [PATCH] coredump: simplify coredump_skip()

Replace the multi-if conditional check with a single return statement.

Signed-off-by: Fushuai Wang <wangfushuai@...du.com>
---
 fs/coredump.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/fs/coredump.c b/fs/coredump.c
index fedbead956ed..3fcbf108099b 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -1077,13 +1077,8 @@ static void coredump_cleanup(struct core_name *cn, struct coredump_params *cprm)
 static inline bool coredump_skip(const struct coredump_params *cprm,
 				 const struct linux_binfmt *binfmt)
 {
-	if (!binfmt)
-		return true;
-	if (!binfmt->core_dump)
-		return true;
-	if (!__get_dumpable(cprm->mm_flags))
-		return true;
-	return false;
+	return (!binfmt || !binfmt->core_dump ||
+		!__get_dumpable(cprm->mm_flags));
 }
 
 void vfs_coredump(const kernel_siginfo_t *siginfo)
-- 
2.36.1