linux-kernel - Re: [PATCH v5.10] scsi: pm80xx: Fix memory leak during rmmod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c7aedbf-389d-4e5a-83d0-33c51cda1d8a@web.de>
Date: Mon, 11 Aug 2025 10:00:40 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Shivani Agarwal <shivani.agarwal@...adcom.com>,
 Sasha Levin <sashal@...nel.org>, Viswas G <Viswas.G@...rochip.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Ajish Koshy <Ajish.Koshy@...rochip.com>, Jack Wang <jinpu.wang@...os.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-scsi@...r.kernel.org
Cc: bcm-kernel-feedback-list@...adcom.com, stable@...r.kernel.org,
 LKML <linux-kernel@...r.kernel.org>, Ajay Kaher <ajay.kaher@...adcom.com>,
 Alexey Makhalov <alexey.makhalov@...adcom.com>,
 Jack Wang <jinpu.wang@...ud.ionos.com>,
 James Bottomley <James.Bottomley@...senPartnership.com>,
 Tapas Kundu <tapas.kundu@...adcom.com>
Subject: Re: [PATCH v5.10] scsi: pm80xx: Fix memory leak during rmmod

…
> +++ b/drivers/scsi/pm8001/pm8001_init.c
…
> @@ -1226,6 +1227,16 @@ static void pm8001_pci_remove(struct pci_dev *pdev)
>  			tasklet_kill(&pm8001_ha->tasklet[j]);
>  #endif
>  	scsi_host_put(pm8001_ha->shost);
> +
> +	for (i = 0; i < pm8001_ha->ccb_count; i++) {
> +		dma_free_coherent(&pm8001_ha->pdev->dev,
> +			sizeof(struct pm8001_prd) * PM8001_MAX_DMA_SG,
> +			pm8001_ha->ccb_info[i].buf_prd,
> +			pm8001_ha->ccb_info[i].ccb_dma_handle);
> +	}

May curly brackets be omitted here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.16#n197

Regards,
Markus