linux-kernel - Re: [PATCH v2] gpio: twl4030: Remove error print for devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <175490341188.22509.3589235210519192885.b4-ty@linaro.org>
Date: Mon, 11 Aug 2025 11:10:18 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Waqar Hameed <waqar.hameed@...s.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	kernel@...s.com,
	linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] gpio: twl4030: Remove error print for devm_add_action_or_reset()

From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>


On Tue, 05 Aug 2025 11:33:33 +0200, Waqar Hameed wrote:
> When `devm_add_action_or_reset()` fails, it is due to a failed memory
> allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do
> anything when error is `-ENOMEM`. Therefore, remove the useless call to
> `dev_err_probe()` when `devm_add_action_or_reset()` fails, and just
> return the value instead.
> 
> 
> [...]

Applied, thanks!

[1/1] gpio: twl4030: Remove error print for devm_add_action_or_reset()
      https://git.kernel.org/brgl/linux/c/0d1e68fb1efd2fe951d68cf05460e3672d4a846d

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>