linux-kernel - Re: [PATCH] mailbox: arm_mhuv3: Remove no_free_ptr() to maintain the original form of the pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJm35DGRj2RZ7W9Q@pluto>
Date: Mon, 11 Aug 2025 10:30:51 +0100
From: Cristian Marussi <cristian.marussi@....com>
To: Liao Yuanhong <liaoyuanhong@...o.com>
Cc: Sudeep Holla <sudeep.holla@....com>,
	Cristian Marussi <cristian.marussi@....com>,
	Jassi Brar <jassisinghbrar@...il.com>,
	"open list:MAILBOX ARM MHUv3" <linux-kernel@...r.kernel.org>,
	"moderated list:MAILBOX ARM MHUv3" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] mailbox: arm_mhuv3: Remove no_free_ptr() to maintain the
 original form of the pointer

On Mon, Aug 11, 2025 at 04:25:36PM +0800, Liao Yuanhong wrote:
> Remove no_free_ptr() to ensure PTR_ERR() consistently retrieves the correct
> error code.
> 

Hi,

> Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
> ---
>  drivers/mailbox/arm_mhuv3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mailbox/arm_mhuv3.c b/drivers/mailbox/arm_mhuv3.c
> index b97e79a5870f..0910da67f8a1 100644
> --- a/drivers/mailbox/arm_mhuv3.c
> +++ b/drivers/mailbox/arm_mhuv3.c
> @@ -945,7 +945,7 @@ static irqreturn_t mhuv3_mbx_comb_interrupt(int irq, void *arg)
>  			if (IS_ERR(data)) {
>  				dev_err(dev,
>  					"Failed to read in-band data. err:%ld\n",
> -					PTR_ERR(no_free_ptr(data)));
> +					PTR_ERR(data));
>  				goto rx_ack;

Yes indeed the cleanup kfree helper takes care to skip any ERR_OR_NULL
by itself...good catch, thanks for this.

Acked-by: Cristian Marussi <cristian.marussi@....com>

Thanks,
Cristian