linux-kernel - RE: [PATCH] cdx: don't select CONFIG_GENERIC_MSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BL1PR12MB5333024F220BFE80912D45FA9D28A@BL1PR12MB5333.namprd12.prod.outlook.com>
Date: Mon, 11 Aug 2025 10:02:22 +0000
From: "Agarwal, Nikhil" <nikhil.agarwal@....com>
To: Arnd Bergmann <arnd@...nel.org>, "Gupta, Nipun" <Nipun.Gupta@....com>
CC: Thomas Gleixner <tglx@...utronix.de>, Marc Zyngier <maz@...nel.org>, Arnd
 Bergmann <arnd@...db.de>, Krzysztof Kozlowski
	<krzysztof.kozlowski@...aro.org>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, Thomas Weißschuu
	<linux@...ssschuh.net>, Qiu-ji Chen <chenqiuji666@...il.com>, Peter Zijlstra
	<peterz@...radead.org>, "Rob Herring (Arm)" <robh@...nel.org>, Robin Murphy
	<robin.murphy@....com>, "Gangurde, Abhijit" <abhijit.gangurde@....com>,
	Nathan Chancellor <nathan@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] cdx: don't select CONFIG_GENERIC_MSI_IRQ



> -----Original Message-----
> From: Arnd Bergmann <arnd@...nel.org>
> Sent: Tuesday, August 5, 2025 9:41 PM
> To: Gupta, Nipun <Nipun.Gupta@....com>; Agarwal, Nikhil
> <nikhil.agarwal@....com>
> Cc: Thomas Gleixner <tglx@...utronix.de>; Marc Zyngier <maz@...nel.org>; Arnd
> Bergmann <arnd@...db.de>; Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>; Thomas Weißschuu <linux@...ssschuh.net>; Qiu-
> ji Chen <chenqiuji666@...il.com>; Peter Zijlstra <peterz@...radead.org>; Rob
> Herring (Arm) <robh@...nel.org>; Robin Murphy <robin.murphy@....com>;
> Gangurde, Abhijit <abhijit.gangurde@....com>; Nathan Chancellor
> <nathan@...nel.org>; linux-kernel@...r.kernel.org
> Subject: [PATCH] cdx: don't select CONFIG_GENERIC_MSI_IRQ
> 
> From: Arnd Bergmann <arnd@...db.de>
> 
> x86 does not use CONFIG_GENERIC_MSI_IRQ, and trying to enable it anyway
> results in a build failure:
> 
> In file included from include/linux/ssb/ssb.h:10,
>                  from drivers/ssb/pcihost_wrapper.c:18:
> include/linux/gpio/driver.h:41:33: error: field 'msiinfo' has incomplete type
>    41 |         msi_alloc_info_t        msiinfo;
>       |                                 ^~~~~~~
> In file included from include/linux/kvm_host.h:19,
>                  from arch/x86/events/intel/core.c:17:
> include/linux/msi.h:528:33: error: field 'alloc_info' has incomplete type
>   528 |         msi_alloc_info_t        alloc_info;
> 
> Change the driver to actually build without this symbol and remove the incorrect
> 'select' statements.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

This change looks fine, but a similar change would be needed in vfio-cdx as 
well, to compile without CONFIG_GENERIC_MSI_IRQ as reported by kernel
test robot. Do you want me to do that patch or will you be updating this?