| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <aJnGLkM-t0aYjzie@fedora>
Date: Mon, 11 Aug 2025 12:30:06 +0200
From: José Expósito <jose.exposito89@...il.com>
To: 卢国宏 <luguohong@...omi.com>
Cc: "jikos@...nel.org" <jikos@...nel.org>,
"bentiss@...nel.org" <bentiss@...nel.org>,
"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Fei1 Jiang 蒋飞 <jiangfei1@...omi.com>
Subject: Re: 答复: [External Mail][PATCH v2 2/2] HID: input: report battery status changes immediately
Hi 卢国宏,
The mailing list won't accept your emails unless you send them
in plain text format. Forwarding it for awareness:
On Mon, Aug 11, 2025 at 04:23:55AM +0000, 卢国宏 wrote:
>
> Hello, José!
> When I submitted your two changes to Google's Android GKI (The patch I compiled is: https://android-review.googlesource.com/c/kernel/common/+/3723411), they raised two issues:
> 1. This patch has no functional changes. Why is a cherry-pick needed?
> 2. FROMGIT patches must cite the source repository, branch, and sha. Please see https://android.googlesource.com/kernel/common/+/refs/heads/android-mainline/README.md
>
> From their documentation, I learned that they recommend submitting the changes as follows:
> Requirements for other backports: FROMGIT:, FROMLIST:,
> If the patch has been merged into an upstream maintainer tree, but has not yet been merged into Linux mainline
> tag the patch subject with FROMGIT:
> add info on where the patch came from as (cherry picked from commit <sha1> <repo> <branch>). This must be a stable maintainer branch (not rebased, so don't use linux-next for example).
> if changes were required, use BACKPORT: FROMGIT:
> Example:
> if the commit message in the maintainer tree is
> important patch from upstream
>
> This is the detailed description of the important patch
>
> Signed-off-by: Fred Jones <fred.jones@....org>
> then Joe Smith would upload the patch for the common kernel as
> FROMGIT: important patch from upstream
>
> This is the detailed description of the important patch
>
> Signed-off-by: Fred Jones <fred.jones@....org>
>
> Bug: 135791357
> (cherry picked from commit 878a2fd9de10b03d11d2f622250285c7e63deace
> https://git.kernel.org/pub/scm/linux/kernel/git/foo/bar.git test-branch)
> Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01
> Signed-off-by: Joe Smith <joe.smith@....org>
> However, I didn't find the information Google mentioned in your email: the source repo, branch, and sha.
> Have you submitted these two patches to the kernel tree? Could you please provide a patch with the information Google needs? Thank you very much!
The patches are not merged yet, that's why you can not find the commit
SHA that you need.
A maintainer will send an email to the ML once the patches are reviewed
and accepted, but they are very busy, so it'll take some time.
Jose
> ________________________________
> 发件人: José Expósito <jose.exposito89@...il.com>
> 发送时间: 2025年8月6日 15:39
> 收件人: jikos@...nel.org
> 抄送: bentiss@...nel.org; 卢国宏; linux-input@...r.kernel.org; linux-kernel@...r.kernel.org; José Expósito
> 主题: [External Mail][PATCH v2 2/2] HID: input: report battery status changes immediately
>
> [外部邮件] 此邮件来源于小米公司外部，请谨慎处理。若对邮件安全性存疑，请将邮件转发给misec@...omi.com进行反馈
>
> When the battery status changes, report the change immediately to user
> space.
>
> Fixes: a608dc1c0639 ("HID: input: map battery system charging")
> Reported-by: 卢国宏 <luguohong@...omi.com>
> Closes: https://lore.kernel.org/linux-input/aI49Im0sGb6fpgc8@fedora/T/
> Tested-by: 卢国宏 <luguohong@...omi.com>
> Signed-off-by: José Expósito <jose.exposito89@...il.com>
> ---
> drivers/hid/hid-input.c | 23 ++++++++++-------------
> 1 file changed, 10 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 262787e6eb20..f45f856a127f 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -609,13 +609,19 @@ static bool hidinput_update_battery_charge_status(struct hid_device *dev,
> return false;
> }
>
> -static void hidinput_update_battery(struct hid_device *dev, int value)
> +static void hidinput_update_battery(struct hid_device *dev, unsigned int usage,
> + int value)
> {
> int capacity;
>
> if (!dev->battery)
> return;
>
> + if (hidinput_update_battery_charge_status(dev, usage, value)) {
> + power_supply_changed(dev->battery);
> + return;
> + }
> +
> if (value == 0 || value < dev->battery_min || value > dev->battery_max)
> return;
>
> @@ -642,13 +648,8 @@ static void hidinput_cleanup_battery(struct hid_device *dev)
> {
> }
>
> -static bool hidinput_update_battery_charge_status(struct hid_device *dev,
> - unsigned int usage, int value)
> -{
> - return false;
> -}
> -
> -static void hidinput_update_battery(struct hid_device *dev, int value)
> +static void hidinput_update_battery(struct hid_device *dev, unsigned int usage,
> + int value)
> {
> }
> #endif /* CONFIG_HID_BATTERY_STRENGTH */
> @@ -1515,11 +1516,7 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct
> return;
>
> if (usage->type == EV_PWR) {
> - bool handled = hidinput_update_battery_charge_status(hid, usage->hid, value);
> -
> - if (!handled)
> - hidinput_update_battery(hid, value);
> -
> + hidinput_update_battery(hid, usage->hid, value);
> return;
> }
>
> --
> 2.50.1
>
> #/******本邮件及其附件含有小米公司的保密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、或散发）本邮件中的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本邮件！ This e-mail and its attachments contain confidential information from XIAOMI, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!******/#
Powered by blists - more mailing lists