linux-kernel - RE: [RFC PATCH 1/8] drm: writeback: Refactor drm_writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM3PPF208195D8D3A33723FD7C3AF6544C8E328A@DM3PPF208195D8D.namprd11.prod.outlook.com>
Date: Mon, 11 Aug 2025 11:14:10 +0000
From: "Kandpal, Suraj" <suraj.kandpal@...el.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
CC: "kernel-list@...pberrypi.com" <kernel-list@...pberrypi.com>,
	"amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"freedreno@...ts.freedesktop.org" <freedreno@...ts.freedesktop.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"intel-xe@...ts.freedesktop.org" <intel-xe@...ts.freedesktop.org>,
	"intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
	"Nautiyal, Ankit K" <ankit.k.nautiyal@...el.com>, "Murthy, Arun R"
	<arun.r.murthy@...el.com>, "Shankar, Uma" <uma.shankar@...el.com>, "Nikula,
 Jani" <jani.nikula@...el.com>, "harry.wentland@....com"
	<harry.wentland@....com>, "siqueira@...lia.com" <siqueira@...lia.com>,
	"alexander.deucher@....com" <alexander.deucher@....com>,
	"christian.koenig@....com" <christian.koenig@....com>, "airlied@...il.com"
	<airlied@...il.com>, "simona@...ll.ch" <simona@...ll.ch>,
	"liviu.dudau@....com" <liviu.dudau@....com>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"mripard@...nel.org" <mripard@...nel.org>, "robin.clark@....qualcomm.com"
	<robin.clark@....qualcomm.com>, "abhinav.kumar@...ux.dev"
	<abhinav.kumar@...ux.dev>, "tzimmermann@...e.de" <tzimmermann@...e.de>,
	"jessica.zhang@....qualcomm.com" <jessica.zhang@....qualcomm.com>,
	"sean@...rly.run" <sean@...rly.run>, "marijn.suijten@...ainline.org"
	<marijn.suijten@...ainline.org>, "laurent.pinchart+renesas@...asonboard.com"
	<laurent.pinchart+renesas@...asonboard.com>, "mcanal@...lia.com"
	<mcanal@...lia.com>, "dave.stevenson@...pberrypi.com"
	<dave.stevenson@...pberrypi.com>, "tomi.valkeinen+renesas@...asonboard.com"
	<tomi.valkeinen+renesas@...asonboard.com>,
	"kieran.bingham+renesas@...asonboard.com"
	<kieran.bingham+renesas@...asonboard.com>, "louis.chauvet@...tlin.com"
	<louis.chauvet@...tlin.com>
Subject: RE: [RFC PATCH 1/8] drm: writeback: Refactor drm_writeback_connector
 structure

> >  static const char *
> > @@ -187,7 +189,8 @@ static int __drm_writeback_connector_init(struct
> drm_device *dev,
> >  					  struct drm_encoder *enc, const u32
> *formats,
> >  					  int n_formats)
> >  {
> > -	struct drm_connector *connector = &wb_connector->base;
> > +	struct drm_connector *connector =
> > +		drm_writeback_to_connector(wb_connector);
> >  	struct drm_mode_config *config = &dev->mode_config;
> >  	struct drm_property_blob *blob;
> >  	int ret = create_writeback_properties(dev); @@ -269,7 +272,8 @@ int
> > drm_writeback_connector_init(struct drm_device *dev,
> >  				 struct drm_encoder *enc,
> >  				 const u32 *formats, int n_formats)  {
> > -	struct drm_connector *connector = &wb_connector->base;
> > +	struct drm_connector *connector =
> > +		drm_writeback_to_connector(wb_connector);
> 
> Please pass drm_connector instead (to all init functions). It would make more
> sense.

Was thinking around the same lines too let's see how other react to this RFC series.

Regards,
Suraj Kandpal

> 
> >  	int ret;
> >
> >  	ret = drm_connector_init(dev, connector, con_funcs, @@ -339,7 +343,8
> > @@ int drmm_writeback_connector_init(struct drm_device *dev,
> >  				  struct drm_encoder *enc,
> >  				  const u32 *formats, int n_formats)  {
> > -	struct drm_connector *connector = &wb_connector->base;
> > +	struct drm_connector *connector =
> > +		drm_writeback_to_connector(wb_connector);
> >  	int ret;
> >
> >  	ret = drmm_connector_init(dev, connector, con_funcs,
> 
> --
> With best wishes
> Dmitry