linux-kernel - Re: [PATCH v5.10] scsi: pm80xx: Fix memory leak during rmmod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025081141-voltage-tribesman-350d@gregkh>
Date: Mon, 11 Aug 2025 13:20:47 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Shivani Agarwal <shivani.agarwal@...adcom.com>,
	bcm-kernel-feedback-list@...adcom.com, linux-scsi@...r.kernel.org,
	Sasha Levin <sashal@...nel.org>, Viswas G <Viswas.G@...rochip.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Ajish Koshy <Ajish.Koshy@...rochip.com>,
	Jack Wang <jinpu.wang@...os.com>, stable@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Ajay Kaher <ajay.kaher@...adcom.com>,
	Alexey Makhalov <alexey.makhalov@...adcom.com>,
	Jack Wang <jinpu.wang@...ud.ionos.com>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Tapas Kundu <tapas.kundu@...adcom.com>
Subject: Re: [PATCH v5.10] scsi: pm80xx: Fix memory leak during rmmod

On Mon, Aug 11, 2025 at 12:50:24PM +0200, Markus Elfring wrote:
> >> May curly brackets be omitted here?
> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.16#n197
> > 
> > Thanks, Markus. I agree with you and have no objection. However, for
> > the stable branches, we usually keep the patches unchanged.
> 
> I am unsure how many source code adjustments would be supported
> also according to coding style concerns.
> 
> 
> > I think it would be good to remove these curly braces in the Linux
> > master branch as well. Should I go ahead and submit a patch for the
> > master branch too?
> 
> Corresponding refinements would be nice.
> https://elixir.bootlin.com/linux/v6.16/source/drivers/scsi/pm8001/pm8001_init.c#L1311-L1316

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot