linux-kernel - Re: [PATCH v1 3/5] dt-bindings: misc: Move amd,sbrmi.yaml from hwmon to misc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52fa4c81-9df5-458e-a07c-5d385e6d1631@amd.com>
Date: Mon, 11 Aug 2025 17:24:18 +0530
From: "Gupta, Akshay" <Akshay.Gupta@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>, linux-kernel@...r.kernel.org,
 linux-hwmon@...r.kernel.org
Cc: gregkh@...uxfoundation.org, arnd@...db.de, linux@...ck-us.net,
 Anand.Umarji@....com,
 Naveen Krishna Chatradhi <naveenkrishna.chatradhi@....com>
Subject: Re: [PATCH v1 3/5] dt-bindings: misc: Move amd,sbrmi.yaml from hwmon
 to misc


On 7/29/2025 11:59 AM, Krzysztof Kozlowski wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On 28/07/2025 08:10, Akshay Gupta wrote:
>> - AMD SB-RMI patches are moved from drivers/hwmon to
>>    drivers/misc to support additional functionality.
>>    Move the related bindings documentation files to misc.
>>
>> Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@....com>
> Really? What was reviewed here exactly? Poor style of commit msg or that
> rename actually does rename?
>
>> Signed-off-by: Akshay Gupta <akshay.gupta@....com>
>> ---
>>   Documentation/devicetree/bindings/{hwmon => misc}/amd,sbrmi.yaml | 0
> We don't put bindings into MISC.

We moved the SB-RMI driver from hwmon to misc, and hence moved the 
binding documentation.

Referred the newly added yaml file, ti,fpc202.yaml through commit in the 
misc bindings.

If Documentation/devicetree/bindings/misc is not right path, can you 
please suggest the correct path for bindings for drivers in misc?

thank you.

>
> <form letter>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
>
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time.
>
> Please kindly resend and include all necessary To/Cc entries.
> </form letter>
>
>
>
>
> Best regards,
> Krzysztof
Sorry, will take care of this.